From: Tom Lane <tgl@sss.pgh.pa.us>
To: heath.lord@crunchydata.com
cc: Daniel Gustafsson <daniel@yesql.se>,
        Jacob Champion <jchampion@timescale.com>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than
 PG14 when SSL is not in use for the connection
In-reply-to: <346263.1664480998@sss.pgh.pa.us>
References: <17625-fc47c78b7d71b534@postgresql.org>
 <346263.1664480998@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 29 Sep 2022 15:49:58 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <360369.1664482580.0@sss.pgh.pa.us>
Date: Thu, 29 Sep 2022 16:16:31 -0400
Message-ID: <360379.1664482591@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/360379.1664482591%40sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <360369.1664482580.1@sss.pgh.pa.us>

I wrote:
> AFAICS that behavioral change is deliberate: for the single case
> of inquiring about "library", PQsslAttribute now tells you which
> SSL implementation libpq *can* use, not which one it's actually
> using on a given connection.  I'm not sure that this is a great
> definition, since it's so unlike the behavior for other attributes.

Actually, wait a minute: both the documentation and the commit
message claim the new behavior is something different than what it
actually is.  The intention seems to have been to change the
behavior only for the conn == NULL case.  So maybe we need to
fix it as attached.  This'd still be broken for the
multiple-libraries scenario, but I admit that that's pretty
hypothetical.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="fix-broken-PQsslAttribute.patch";
	charset="us-ascii"
Content-ID: <360369.1664482580.2@sss.pgh.pa.us>
Content-Description: fix-broken-PQsslAttribute.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/lib=
pq/fe-secure-openssl.c
index aea4661736..e2eace2bc6 100644
--- a/src/interfaces/libpq/fe-secure-openssl.c
+++ b/src/interfaces/libpq/fe-secure-openssl.c
@@ -1745,14 +1745,18 @@ PQsslAttributeNames(PGconn *conn)
 const char *
 PQsslAttribute(PGconn *conn, const char *attribute_name)
 {
-	if (strcmp(attribute_name, "library") =3D=3D 0)
-		return "OpenSSL";
-
 	if (!conn)
+	{
+		if (strcmp(attribute_name, "library") =3D=3D 0)
+			return "OpenSSL";
 		return NULL;
+	}
 	if (conn->ssl =3D=3D NULL)
 		return NULL;
 =

+	if (strcmp(attribute_name, "library") =3D=3D 0)
+		return "OpenSSL";
+
 	if (strcmp(attribute_name, "key_bits") =3D=3D 0)
 	{
 		static char sslbits_str[12];

------- =_aaaaaaaaaa0--