Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNPjD-000449-LL for pgsql-bugs@arkaria.postgresql.org; Sat, 20 Mar 2021 00:44:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lNPcN-0000Yj-JS for pgsql-bugs@arkaria.postgresql.org; Sat, 20 Mar 2021 00:37:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNPcN-0000Yc-Cv for pgsql-bugs@lists.postgresql.org; Sat, 20 Mar 2021 00:37:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNPcL-0001cF-Fn for pgsql-bugs@lists.postgresql.org; Sat, 20 Mar 2021 00:37:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 12K0bH00000363; Fri, 19 Mar 2021 20:37:17 -0400 From: Tom Lane To: Andres Freund cc: Regina Obe , "'Heikki Linnakangas'" , "'Juan =?utf-8?B?Sm9zw6kgU2FudGFtYXLDrWE=?= Flecha'" , "'PostgreSQL mailing lists'" Subject: Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head In-reply-to: <20210320001748.n5zkqsafuiwk7txp@alap3.anarazel.de> References: <002d01d7183d$dda66420$98f32c60$@pcorp.us> <2730776.1615672184@sss.pgh.pa.us> <2735801.1615678739@sss.pgh.pa.us> <000d01d71869$2dabde70$89039b50$@pcorp.us> <0bf7c953-ea90-7c74-0f97-4e0e83d09dc9@iki.fi> <2850891.1615712! ! 197@sss.pgh.pa.us> <2 872301.1615744731@sss.pgh.pa.us> <000501d71932$7da0fa40$78e2eec0$@pcorp.us> <3009860.1615824779@sss.pgh.pa.us> <20210320001748.n5zkqsafuiwk7txp@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Fri, 19 Mar 2021 17:17:48 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <361.1616200637.1@sss.pgh.pa.us> Date: Fri, 19 Mar 2021 20:37:17 -0400 Message-ID: <362.1616200637@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2021-03-15 12:12:59 -0400, Tom Lane wrote: >> Although I remain worried about this being an ABI break, I don't think >> we are locked into it until we get to beta, or maybe even RC stage. > Could it make sense to define sigjmp_buf as a union over the potentially > needed implementations? That'd allow us to switch back without an ABI > break if we discover a problem with the gcc approach. No, it'd still be an ABI break, because the setjmp and the longjmp calls have to use the same implementation. Ain't gonna work if elog.c tries to throw via mingw's longjmp() while some extension contains a PG_TRY that uses __builtin_setjmp(). Nor vice versa. regards, tom lane