From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Fujii Masao <masao.fujii@gmail.com>, Sergei Kornilov <sk@zsrv.org>,
        =?utf-8?B?0J7Qu9C10LMg0KHQsNC80L7QudC70L7Qsg==?= <splarv@ya.ru>,
        pgsql-bugs@lists.postgresql.org,
        =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
Subject: Re: basic_archive lost archive_directory
In-reply-to: <aZzI59OB6SaChOgJ@nathan>
References: <202601301728.sfkizrto3t5i@alvherre.pgsql> <9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru> <1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215> <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com> <aYpYaRipZ_-lYxNY@nathan> <CAHGQGwFzC+HYEwJGhpmu1NBiQp_Ln8t0z9CDt8QCQDnUtFAFYA@mail.gmail.com> <aYtXgaKfiYpaqQyW@nathan> <aYzxJy0icsGM1A6u@nathan> <aZzI59OB6SaChOgJ@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Mon, 23 Feb 2026 15:38:47 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3626573.1771885335.1@sss.pgh.pa.us>
Date: Mon, 23 Feb 2026 17:22:15 -0500
Message-ID: <3626574.1771885335@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3626574.1771885335%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Wed, Feb 11, 2026 at 03:14:15PM -0600, Nathan Bossart wrote:
>> On Tue, Feb 10, 2026 at 10:06:25AM -0600, Nathan Bossart wrote:
>>> As I mentioned upthread, IMHO we should simply remove the existence check
>>> from the GUC check hook.  basic_archive must already be written to handle
>>> the archive directory disappearing at any moment, so we should be able to
>>> rely on it without the extra stat().

> Any thoughts?  I'll wait another week or so, but then will proceed with
> committing/back-patching this.

Agreed --- this seems like a pretty inappropriate check to be making
in a check_hook.

			regards, tom lane