Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xRauF-000000016LD-2ucw for pgsql-bugs@arkaria.postgresql.org; Thu, 12 Nov 2026 19:56:23 +0000 Received: from localhost ([127.0.0.1]:42422 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xRauE-00000004d0c-1s67 for pgsql-bugs@arkaria.postgresql.org; Thu, 12 Nov 2026 19:56:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:44574) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xRauE-00000004d0O-0OwG for pgsql-bugs@lists.postgresql.org; Thu, 12 Nov 2026 19:56:22 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xRauB-00000000jO7-3bOT for pgsql-bugs@lists.postgresql.org; Thu, 12 Nov 2026 19:56:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 6ACJuDcQ362807; Thu, 12 Nov 2026 14:56:13 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 sss.pgh.pa.us 6ACJuDcQ362807 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sss.pgh.pa.us; s=default; t=1794513373; bh=+C5FO8/1p9dc0FaQTBt5MRrWUx0QEW4EvZ3PlfhNp7s=; h=From:To:cc:Subject:In-reply-to:References:Date:From; b=glW2U3srjcf0rZ2gkr/vzE2/Qwc705EIlbELA7docrwvJfcp9l9kDA7TteaSzITT+ lrqZoties7k0bIgdi7y12IB69HRkKis+G5xhvtyHaVW4Q2fBFaNVCx/r9zib8Q/pdE xT4fuj+FZaQ2XQ4eZk/C9twbainho7wmi+R8298A= From: Tom Lane To: Atisss hh <125atishprak@gmail.com> cc: pgsql-bugs@lists.postgresql.org, Peter Eisentraut Subject: Re: BUG #19848: BEGIN ATOMIC with unnamed/OUT params breaks restore and pg_upgrade In-reply-to: References: <19848-c4d5bc38ad4ab8b8@postgresql.org> <3773206.1794453200@sss.pgh.pa.us> Comments: In-reply-to Atisss hh <125atishprak@gmail.com> message dated "Thu, 12 Nov 2026 21:52:29 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <362805.1794513373.1@sss.pgh.pa.us> Date: Thu, 12 Nov 2026 14:56:13 -0500 Message-ID: <362806.1794513373@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Atisss hh <125atishprak@gmail.com> writes: > I tested your patch on current master. All the cases from my report now > create, dump and restore with identical results, and the core regression > tests (243) and plsample pass. pg_upgrade from a patched build to a patched > build works. Upgrading from 18.6 still fails with the empty identifier, > since the old server does the deparsing, so this would also need > backpatching to 18 to help pg_upgrade from there. Yeah, it needs back-patching. I did that and pushed it. > Agreed that the q2 case is a scoping problem and not part of this bug. > I don't have a better idea than printing $n, since any qualified name > can be captured by a FROM item with the same name. I'll wait to see if Peter has a better idea before doing anything about that part. The problem would only arise with a function name that matches a table alias in some query within the function; which is certainly possible but it must not be common, else we'd have heard about this years ago. regards, tom lane