From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: bokanist@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17840: Failing to execute auto_explain for logging leads to
 transaction rollback.
In-reply-to: 
 <CAKFQuwa2efAF3VWVVoSQBMUTYx3FsERx2y+o93yToEHL88kwzw@mail.gmail.com>
References: <17840-c480ed3600feea0e@postgresql.org>
 <2558506.1678803048@sss.pgh.pa.us>
 <CANtq+vQC+qqvrVeeLF3fnRRV28hpj0Vjz592Wxm8vYLFXvPZEA@mail.gmail.com>
 <CAKFQuwa2efAF3VWVVoSQBMUTYx3FsERx2y+o93yToEHL88kwzw@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Wed, 15 Mar 2023 12:33:46 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3632529.1678917985.1@sss.pgh.pa.us>
Date: Wed, 15 Mar 2023 18:06:25 -0400
Message-ID: <3632530.1678917985@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3632530.1678917985%40sss.pgh.pa.us>
Precedence: bulk

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> A query you can execute should be incapable of failing if EXPLAIN for the
> same query is issued.

Indeed.  This should be especially true for auto_explain, which isn't
even doing a re-parse or re-plan, but just dumping data from the
executor state tree for the just-finished query.  Barring edge cases
like out-of-memory, it really shouldn't fail; so I see no reason why
we should consider major structural changes to make it (perhaps) less
likely to fail.

I continue to think that the most likely explanation is oracle_fdw
doing something it probably shouldn't be doing.  I have no interest
in poking into that code myself, though.

			regards, tom lane