From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
cc: Virender Singla <virender.cse@gmail.com>, pgsql-bugs@lists.postgresql.org,
        Aniket Jha <aniketkumarj@gmail.com>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
In-reply-to: <202502131716.7mgkcnrem2hn@alvherre.pgsql>
References: <202502131716.7mgkcnrem2hn@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
	message dated "Thu, 13 Feb 2025 18:16:02 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3663281.1739467987.1@sss.pgh.pa.us>
Date: Thu, 13 Feb 2025 12:33:07 -0500
Message-ID: <3663282.1739467987@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3663282.1739467987%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
> Hmm, I think fixing the bug as Tom suggests downthread is probably a
> good idea, but I think we should in addition change pg_dumpall to avoid
> printing a GRANT line if there's no grantee.

On the one hand, my proposed patch can do nothing to fix existing
dangling entries in pg_auth_members, so hacking pg_dump seems like
a good workaround if the problem already exists.  On the other hand,
if we make pg_dump do that then we won't detect future problems of
the same ilk.

> Maybe turning one of these LEFT
> JOINs into a regular inner join is a sufficient fix for that:

Probably change all three, if we're to do this at all.

			regards, tom lane