From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Masahiko Sawada <sawada.mshk@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Dmitry Koval <d.koval@postgrespro.ru>,
        Dilip Kumar <dilipbalaut@gmail.com>, andrewbille@gmail.com,
        pgsql-bugs@lists.postgresql.org,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable
 transaction causes Assert at the transaction end
In-reply-to: <YzJwcL71yaWqCVJ1@paquier.xyz>
References: 
 <CAD21AoDWHkBBGvvJuLEBqMjiPiYOiVJ6voFBWYbOBsU+-Cot2A@mail.gmail.com>
 <20220628003720.GG19662@telsasoft.com>
 <CAD21AoBz4xZ3uOZS+xYENsYta4PPPkGYPDzzPqqw5GJgrQC7hg@mail.gmail.com>
 <Yrv1nRsfasco768G@paquier.xyz>
 <CAD21AoC8FQqHY8knG7+6-eQe39wjXPtqyki29OAb5OHhq7-p+Q@mail.gmail.com>
 <CAD21AoD6n62NXB5OuYSONYHKNkR=fqvJ5+82y=4Z=-KuFeOV0w@mail.gmail.com>
 <2604497.1664053071@sss.pgh.pa.us> <YzEfR9UUb3gqRjoA@paquier.xyz>
 <3268290.1664165270@sss.pgh.pa.us> <YzJwcL71yaWqCVJ1@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 27 Sep 2022 12:39:28 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3667393.1664287017.1@sss.pgh.pa.us>
Date: Tue, 27 Sep 2022 09:56:57 -0400
Message-ID: <3667394.1664287017@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3667394.1664287017%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> As we are talking about a description with GUC_ACTION_SAVE, something
> like "Parameters with this flag do not support RESET, or SET in the
> context of a function call"?  NO_RESET sounds a bit confusing as a
> name if you consider this second part (it can be understood as
> resetting the value as well), but keeping it as-is does not look like
> a big deal to me with this description, or an equivalent, in place.

Yeah, we already talked upthread about how the SAVE restriction makes
"NO_RESET" a bit of a misnomer.  Nobody proposed a better name though.

			regards, tom lane