From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        "zedaardv@drizzle.com" <zedaardv@drizzle.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17720: pg_dump creates a dump with primary key that cannot
 be restored, when specifying 'using index ...'
In-reply-to: <9D3BC528-79FA-4440-9701-6CE8D9D90F41@yesql.se>
References: <17720-dab8ee0fa85d316d@postgresql.org>
 <CAKFQuwam=1NoSNH=EJRUnuuD8JE_jM8tq22-SYqO1nxzoXFwzg@mail.gmail.com>
 <9C039DE3-EFBD-4D65-B4CF-90D8148B7B4C@yesql.se>
 <2684951.1671032222@sss.pgh.pa.us>
 <20CD10FD-A9C2-47D0-9A75-B86532BC058E@yesql.se>
 <3039077.1671060472@sss.pgh.pa.us>
 <173834de-18a1-4a9c-5e15-9b22e56c4293@enterprisedb.com>
 <9D3BC528-79FA-4440-9701-6CE8D9D90F41@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Fri, 16 Dec 2022 17:03:15 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3682341.1671207137.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 16 Dec 2022 11:12:17 -0500
Message-ID: <3682342.1671207137@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3682342.1671207137%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> The attached removes the change from pg_dump and only prohibits the ALTE=
R TABLE
> command for attaching the index.  Since it will render dumps unable to b=
e
> restored I also added a check to pg_upgrade to cover the case.

That doesn't seem like a great answer.  I understood Peter to be
favoring both aspects of the previous patch.

			regards, tom lane