Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1n98cm-00072a-Ic
	for pgsql-bugs@arkaria.postgresql.org; Sun, 16 Jan 2022 16:43:24 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1n98cl-0001f5-8X
	for pgsql-bugs@arkaria.postgresql.org; Sun, 16 Jan 2022 16:43:23 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1n98cl-0001ew-0Z
	for pgsql-bugs@lists.postgresql.org; Sun, 16 Jan 2022 16:43:23 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1n98ce-0000KA-Np
	for pgsql-bugs@postgresql.org; Sun, 16 Jan 2022 16:43:22 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20GGhEr43704261;
	Sun, 16 Jan 2022 11:43:14 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Barton <barton.tomas@gmail.com>
cc: pgsql-bugs@postgresql.org
Subject: Re: pg_upgrade --check doesn't check pg_pltemplate modifications
In-reply-to: 
 <CAPV2KRg3752VbyjTtkEeACNbqRtT82TqsMfioo4nVgY8U+Cs=Q@mail.gmail.com>
References: 
 <CAPV2KRg3752VbyjTtkEeACNbqRtT82TqsMfioo4nVgY8U+Cs=Q@mail.gmail.com>
Comments: In-reply-to Tomas Barton <barton.tomas@gmail.com>
	message dated "Sun, 16 Jan 2022 14:05:23 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3704259.1642351394.1@sss.pgh.pa.us>
Date: Sun, 16 Jan 2022 11:43:14 -0500
Message-ID: <3704260.1642351394@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/3704260.1642351394%40sss.pgh.pa.us>
Precedence: bulk

Tomas Barton <barton.tomas@gmail.com> writes:
> Any non-default GRANT/REVOKE like these:

> REVOKE SELECT ON TABLE "pg_catalog"."pg_pltemplate" FROM PUBLIC;
> GRANT SELECT ON TABLE "pg_catalog"."pg_pltemplate" TO "reader";

Uh ... why would you do that?  It seems only academically
different from randomly deleting some catalog entries.

> would break the upgrade process, even though the pg_upgrade --check says:
> *Clusters are compatible*

pg_upgrade has never promised to detect every possible problem.
Considering that pg_pltemplate is gone entirely in v13 and up,
I doubt we're going to want to invest a lot of effort here.

			regards, tom lane