Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldGGg-0007oW-LQ for pgsql-hackers@arkaria.postgresql.org; Sun, 02 May 2021 17:52:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ldGGf-0005Rv-Ii for pgsql-hackers@arkaria.postgresql.org; Sun, 02 May 2021 17:52:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldGGf-0005R5-Bk for pgsql-hackers@lists.postgresql.org; Sun, 02 May 2021 17:52:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldGGd-0002TF-FB for pgsql-hackers@lists.postgresql.org; Sun, 02 May 2021 17:52:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 142HqR0m3712261; Sun, 2 May 2021 13:52:27 -0400 From: Tom Lane To: Alexander Korotkov cc: PostgreSQL Hackers , Valentin Gatien-Baron , Teodor Sigaev , Oleg Bartunov Subject: Re: websearch_to_tsquery() returns queries that don't match to_tsvector() In-reply-to: References: Comments: In-reply-to Alexander Korotkov message dated "Sun, 02 May 2021 20:45:18 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3712259.1619977947.1@sss.pgh.pa.us> Date: Sun, 02 May 2021 13:52:27 -0400 Message-ID: <3712260.1619977947@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alexander Korotkov writes: > It seems there is another bug with phrase search and query parsing. > It seems to me that since 0c4f355c6a websearch_to_tsquery() should > just parse text in quotes as a single token. Besides fixing this bug, > it simplifies the code. OK ... > Trying to fix this bug before 0c4f355c6a doesn't seem to worth the efforts. Agreed, plus it doesn't sound like the sort of behavior change that we want to push out in minor releases. > I propose to push the attached patch to v14. Objections? This patch seems to include some unrelated fooling around in GiST? regards, tom lane