From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Valentin Gatien-Baron <valentin.gatienbaron@gmail.com>,
        Teodor Sigaev <teodor@postgrespro.ru>,
        Oleg Bartunov <obartunov@postgrespro.ru>
Subject: Re: websearch_to_tsquery() returns queries that don't match
 to_tsvector()
In-reply-to: 
 <CAPpHfdsbr7OX+9F3S8igH5fJkyQwE_g5J4DMEiLwM0=4+nQxZw@mail.gmail.com>
References: 
 <CA+0DEqiZs7gdOd4ikmg=0UWG+SwWOLxPsk_JW-sx9WNOyrb0KQ@mail.gmail.com>
 <CAPpHfdsKy5TzOTq5aV8tn+KQEd_C5mF0Sd_BrZ0e3+wGY5tLFw@mail.gmail.com>
 <3712260.1619977947@sss.pgh.pa.us>
 <CAPpHfdsbr7OX+9F3S8igH5fJkyQwE_g5J4DMEiLwM0=4+nQxZw@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <aekorotkov@gmail.com>
	message dated "Sun, 02 May 2021 20:57:00 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3712827.1619978696.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sun, 02 May 2021 14:04:56 -0400
Message-ID: <3712828.1619978696@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3712828.1619978696%40sss.pgh.pa.us>
Precedence: bulk

Alexander Korotkov <aekorotkov@gmail.com> writes:
> Ooops, I've included this by oversight.  The next revision is attached.
> Anything besides that?

Some quick eyeball review:

+                    /* Everything is quotes is processed as a single token */

Should read "Everything in quotes ..."

-                    /* or else gettoken_tsvector() will raise an error */
+                    /* or else ƒtsvector() will raise an error */

Looks like an unintentional change?

@@ -846,7 +812,6 @@ parse_tsquery(char *buf,
 	state.buffer = buf;
 	state.buf = buf;
 	state.count = 0;
-	state.in_quotes = false;
 	state.state = WAITFIRSTOPERAND;
 	state.polstr = NIL;

This change seems wrong/unsafe too.

			regards, tom lane