Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldGyf-0001LH-PT for pgsql-hackers@arkaria.postgresql.org; Sun, 02 May 2021 18:38:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ldGye-0001Nj-Ly for pgsql-hackers@arkaria.postgresql.org; Sun, 02 May 2021 18:38:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldGye-0001Nc-FW for pgsql-hackers@lists.postgresql.org; Sun, 02 May 2021 18:38:00 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldGyd-0003T5-3l for pgsql-hackers@lists.postgresql.org; Sun, 02 May 2021 18:38:00 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 142IbuQD3714273; Sun, 2 May 2021 14:37:56 -0400 From: Tom Lane To: Alexander Korotkov cc: PostgreSQL Hackers , Valentin Gatien-Baron , Teodor Sigaev , Oleg Bartunov Subject: Re: websearch_to_tsquery() returns queries that don't match to_tsvector() In-reply-to: References: <3712260.1619977947@sss.pgh.pa.us> <3712828.1619978696@sss.pgh.pa.us> Comments: In-reply-to Alexander Korotkov message dated "Sun, 02 May 2021 21:12:11 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3714271.1619980676.1@sss.pgh.pa.us> Date: Sun, 02 May 2021 14:37:56 -0400 Message-ID: <3714272.1619980676@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alexander Korotkov writes: > On Sun, May 2, 2021 at 9:04 PM Tom Lane wrote: >> - state.in_quotes = false; >> >> This change seems wrong/unsafe too. > It seems OK, because this patch removes in_quotes field altogether. Oh, sorry, I misread the patch --- I thought that earlier hunk was removing a local variable. Agreed, if you can do without this state field altogether, that's fine. regards, tom lane