From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrey Borodin <x4mmm@yandex-team.ru>
cc: Andrey Rachitskiy <pl0h0yp1@gmail.com>, ilia.kashintsev@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19613: pg_restore: several SEGVs in ReadToc() in
 pg_backup_archiver.c
In-reply-to: <09D266FA-E7FE-4816-B5A3-EEF13140D7F0@yandex-team.ru>
References: <19613-3a9ffc23ee402382@postgresql.org>
 <CAB8bMisXgPyHXQeiPTbemp_uANRXPUgyytbDsMfywJGyAqvDOA@mail.gmail.com>
 <09D266FA-E7FE-4816-B5A3-EEF13140D7F0@yandex-team.ru>
Comments: In-reply-to Andrey Borodin <x4mmm@yandex-team.ru>
	message dated "Fri, 14 Aug 2026 14:58:23 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3767379.1786725187.1@sss.pgh.pa.us>
Date: Fri, 14 Aug 2026 12:33:07 -0400
Message-ID: <3767380.1786725187@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3767380.1786725187%40sss.pgh.pa.us>
Precedence: bulk

Andrey Borodin <x4mmm@yandex-team.ru> writes:
> Could we add a regression test?

-1 ... I think the engineering, maintenance, and runtime cost of a
test like this would never pay for itself.  The thing you would wish
that a regression test could catch is adding a new TOC field that is
effectively required while failing to use ReadRequiredStr for it.
Which a test like this wouldn't.

			regards, tom lane