From: Tom Lane <tgl@sss.pgh.pa.us>
To: Maaz Syed Adeeb <maaz.adeeb@gmail.com>
cc: pgsql-bugs@lists.postgresql.org, matthew.ripley28@gmail.com
Subject: Re: CREATE INDEX with an expression in an INCLUDE column fails with
 XX000 "unrecognized node type" instead of 0A000 on master
In-reply-to: 
 <CAG+FJqMUxTXMhFrShEfygnONTS-_yBJYwabwWS0G26hNDfv+DA@mail.gmail.com>
References: 
 <CAG+FJqOxYj=sVyHcys64h9DbvzP6EUPGHJ7oKj-PW=Qp5Ebk_g@mail.gmail.com>
 <3574719.1784140144@sss.pgh.pa.us>
 <CAG+FJqN84B4KjmMp2oR2wSJUiEbgG1SV78wncUmi2Cz1qvDUOA@mail.gmail.com>
 <3577449.1784142765@sss.pgh.pa.us>
 <CAG+FJqMUxTXMhFrShEfygnONTS-_yBJYwabwWS0G26hNDfv+DA@mail.gmail.com>
Comments: In-reply-to Maaz Syed Adeeb <maaz.adeeb@gmail.com>
	message dated "Wed, 15 Jul 2026 22:20:36 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3789750.1784217864.1@sss.pgh.pa.us>
Date: Thu, 16 Jul 2026 12:04:24 -0400
Message-ID: <3789751.1784217864@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3789751.1784217864%40sss.pgh.pa.us>
Precedence: bulk

Maaz Syed Adeeb <maaz.adeeb@gmail.com> writes:
> Attaching a patch with two regress tests. Let me know if I need to
> change anything.

Thanks.  index_including.sql embodies all sorts of anti-patterns
for testing: use of very generic object names that could conflict
with concurrent test scripts, constant dropping and re-creation
of objects ensuring that the overhead per useful test is as high
as possible, etc.  But it's not the job of this patch to improve
that, so I guess the fact that you faithfully copied the existing
style is fine.  I used your test as-is and pushed it.  Thanks
again for the report!

			regards, tom lane