Content-Type: multipart/mixed; boundary="------------a43CBS2zoQXCdbCi4cafTWDM"
Message-ID: <379082d6-1b6a-4cd6-9ecf-7157d8c08635@postgrespro.ru>
Date: Thu, 28 Sep 2023 12:07:48 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
 David Rowley <dgrowleyml@gmail.com>
Content-Language: en-US
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Subject: Missed TidRangePath in the print_path switch
Organization: Postgres Professional
Archived-At: 
 <https://www.postgresql.org/message-id/379082d6-1b6a-4cd6-9ecf-7157d8c08635%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------a43CBS2zoQXCdbCi4cafTWDM
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

The TidRangePath node was introduced three years ago. However, path 
printing machinery still does not support it. It isn't enjoyable to add 
this string of code each time. I suggest adding it now.
Also, I propose not printing "???path" in the default case but throwing 
a warning - see the patch in the attachment. It can help to avoid such 
slip-ups next time.
It generally makes sense to generate such long switches automatically, 
likewise nodeToString.

-- 
regards,
Andrey Lepikhov
Postgres Professional
--------------a43CBS2zoQXCdbCi4cafTWDM
Content-Type: text/plain; charset=UTF-8; name="tidrangepath.patch"
Content-Disposition: attachment; filename="tidrangepath.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2FsbHBhdGhzLmMgYi9z
cmMvYmFja2VuZC9vcHRpbWl6ZXIvcGF0aC9hbGxwYXRocy5jCmluZGV4IDliZGM3MGM3MDIu
LmIwZWQ2OWQyZjggMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL29wdGltaXplci9wYXRoL2Fs
bHBhdGhzLmMKKysrIGIvc3JjL2JhY2tlbmQvb3B0aW1pemVyL3BhdGgvYWxscGF0aHMuYwpA
QCAtNDQ3MCw2ICs0NDcwLDkgQEAgcHJpbnRfcGF0aChQbGFubmVySW5mbyAqcm9vdCwgUGF0
aCAqcGF0aCwgaW50IGluZGVudCkKIAkJY2FzZSBUX1RpZFBhdGg6CiAJCQlwdHlwZSA9ICJU
aWRTY2FuIjsKIAkJCWJyZWFrOworCQljYXNlIFRfVGlkUmFuZ2VQYXRoOgorCQkJcHR5cGUg
PSAiVGlkUmFuZ2VQYXRoIjsKKwkJCWJyZWFrOwogCQljYXNlIFRfU3VicXVlcnlTY2FuUGF0
aDoKIAkJCXB0eXBlID0gIlN1YnF1ZXJ5U2NhbiI7CiAJCQlicmVhazsKQEAgLTQ1NzgsNyAr
NDU4MSw4IEBAIHByaW50X3BhdGgoUGxhbm5lckluZm8gKnJvb3QsIFBhdGggKnBhdGgsIGlu
dCBpbmRlbnQpCiAJCQlzdWJwYXRoID0gKChMaW1pdFBhdGggKikgcGF0aCktPnN1YnBhdGg7
CiAJCQlicmVhazsKIAkJZGVmYXVsdDoKLQkJCXB0eXBlID0gIj8/P1BhdGgiOworCQkJZWxv
ZyhXQVJOSU5HLCAiY291bGQgbm90IHByaW50IHVucmVjb2duaXplZCBub2RlIHR5cGU6ICVk
IiwKKwkJCQkgKGludCkgbm9kZVRhZyhwYXRoKSk7CiAJCQlicmVhazsKIAl9CiAK

--------------a43CBS2zoQXCdbCi4cafTWDM--