From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
cc: michael@paquier.xyz, robertmhaas@gmail.com, christoph.berg@credativ.de,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17504: psql --single-transaction -vON_ERROR_STOP=1 still
 commits after client-side error
In-reply-to: <20220613.160701.975499861789120736.horikyota.ntt@gmail.com>
References: <2649417.1654875709@sss.pgh.pa.us>
 <2656555.1654877531@sss.pgh.pa.us> <Yqbc8bAdwnP02na4@paquier.xyz>
 <20220613.160701.975499861789120736.horikyota.ntt@gmail.com>
Comments: In-reply-to Kyotaro Horiguchi <horikyota.ntt@gmail.com>
	message dated "Mon, 13 Jun 2022 16:07:01 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3791928.1655131936.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 13 Jun 2022 10:52:16 -0400
Message-ID: <3791929.1655131936@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3791929.1655131936%40sss.pgh.pa.us>
Precedence: bulk

Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> At Mon, 13 Jun 2022 15:45:05 +0900, Michael Paquier <michael@paquier.xyz=
> wrote in =

>> This suggestion does not look right to me with --single-transaction.
>> If not using ON_ERROR_STOP, I think that we should still loop through
>> all the switches given by the caller and force a COMMIT all the time
>> because the intention is that we don't care about failures while
>> processing.  This gives me the attached as a result for HEAD, where we

> Agreed. It is actually a bug that on_error_stop is ignored here.

Sounds plausible to me too.

>> Now, do we really want to introduce this new behavior on HEAD?  We are
>> post-beta so this does not me make me really comfortable if both
>> Robert and you don't like the change, even if the behavior of
>> --single-transaction/ON_ERROR_STOP on client-side failure is weird to
>> me and others from upthread.

I think it's fine to commit this to HEAD.  The reason for reverting
in the back branches was exactly that we'd already changed the behavior;
and what we now see is that it's still buggy and we need to change it
some more.  That's an entirely appropriate thing to be doing in beta.

			regards, tom lane