From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Alexander Lakhin <exclusion@gmail.com>, kyzevan23@mail.ru,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17874: Incorrect memory access at gistBuildCallback
In-reply-to: <E718477B-9693-4BAF-B4E9-8FE36C3EB986@yesql.se>
References: <17874-63ca6c7ce42d2103@postgresql.org>
 <6341c61d-e6cd-bc68-8a8b-8b307b6f9359@gmail.com>
 <E718477B-9693-4BAF-B4E9-8FE36C3EB986@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Wed, 29 Mar 2023 12:11:09 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3802069.1680090432.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 29 Mar 2023 07:47:12 -0400
Message-ID: <3802070.1680090432@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3802070.1680090432%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 29 Mar 2023, at 12:00, Alexander Lakhin <exclusion@gmail.com> wrote:
>> That issue was reported already as bug #16329:
>> https://www.postgresql.org/message-id/flat/16329-7a6aa9b6fa1118a1%40pos=
tgresql.org
>> Maybe it's worth to register the fix proposed there for the next commit=
fest...

> Summarizing that thread and registering the proposed patch for the next
> commitfest seems like the right thing to do.

Yeah.  We did fix the lack of test coverage that much of that thread
was about, but it seems like we forgot the original bug (which I
guess indicates that the coverage is still inadequate, since the
valgrind buildfarm animals haven't noticed it...)

			regards, tom lane