Message-ID: <3894d2a91d141b0fe454da01b3b7faad6fa9d07a.camel@aegee.org>
Subject: Re: No libldap_r in OpenLDAP 2.5 - use
 LDAP_API_FEATURE_X_OPENLDAP_REENTRANT from ldap_features.h
From: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?=
	=?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?=
	 <dilyan.palauzov@aegee.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Date: Wed, 25 Aug 2021 10:07:40 +0300
In-Reply-To: <520273.1629872978@sss.pgh.pa.us>
References: <20210825052142.Horde.fX47Irhz5YmXoRVbIbyYUJm@webmail.aegee.org>
	 <520273.1629872978@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.41.3 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/3894d2a91d141b0fe454da01b3b7faad6fa9d07a.camel%40aegee.org>
Precedence: bulk

Hello Tom,

on my system I have installed first OpenLDAP 2.4, and then in addition
OpenLDAP 2.5.  The problem is, that postgresql (daemon) links with
libldap-2.5, and libpq links with libldap_r-2.4 . So any executable
(e.g. php) which links with both libldap and libpq, loads at the end at
the same time libldap-2.5 andl libldap_r-2.4 - two different versions.
This is not good.

When libldap( 2.5) is reentrant, and when libldap_r-2.4 is present,
libldap_r-2.4 shall not be used for linking.

Greetings
  Дилян


On Wed, 2021-08-25 at 02:29 -0400, Tom Lane wrote:
> Dilyan Palauzov <Dilyan.Palauzov@aegee.org> writes:
> > The current postgres/configure.ac logic is: if libldap_r is
> > availabe,  
> > then use it, otherwise use libldap.
> 
> Right.
> 
> > I propose, instead of looking for the presence of libldap_r, to
> > check  
> > the feature macro, and if libldap is reentrant, not to use
> > libldap_r .
> 
> Why?  This seems more fragile (i.e., it adds an assumption that the
> visible header file matches the available libraries), and if there is
> a concrete benefit, you did not say what that is.
> 
>                         regards, tom lane