Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1noAcr-0006gJ-Oh
	for pgsql-bugs@arkaria.postgresql.org; Mon, 09 May 2022 21:09:05 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1noAcq-00026K-5l
	for pgsql-bugs@arkaria.postgresql.org; Mon, 09 May 2022 21:09:04 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1noAcp-00026A-Tp
	for pgsql-bugs@lists.postgresql.org; Mon, 09 May 2022 21:09:03 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1noAcm-0008Gy-Mr
	for pgsql-bugs@lists.postgresql.org; Mon, 09 May 2022 21:09:02 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 249L8tmX3927832;
	Mon, 9 May 2022 17:08:55 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Masahiko Sawada <sawada.mshk@gmail.com>, krking@zju.edu.cn,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17477: A crash bug in transformValuesClause()
In-reply-to: <202205092055.n227skur4e3a@alvherre.pgsql>
References: <202205092055.n227skur4e3a@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Mon, 09 May 2022 22:55:06 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3927830.1652130535.1@sss.pgh.pa.us>
Date: Mon, 09 May 2022 17:08:55 -0400
Message-ID: <3927831.1652130535@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/3927831.1652130535%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Looking at the code, I understand that what your patch is doing is
> making the zeroth case no longer a special one but rather handled it in
> the same loop block as the other cases, which is why the bug is fixed.
> LGTM.

Thanks for looking!  With the time constraint being what it is,
the more eyes on the patch the better.

			regards, tom lane