From: Tom Lane <tgl@sss.pgh.pa.us>
To: Maaz Syed Adeeb <maaz.adeeb@gmail.com>
cc: pgsql-bugs@lists.postgresql.org, matthew.ripley28@gmail.com
Subject: Re: CREATE INDEX with an expression in an INCLUDE column fails with
 XX000 "unrecognized node type" instead of 0A000 on master
In-reply-to: 
 <CAG+FJqNpLQZ5uc321W8oC7M8VzGmuJQx6vCkzrxHzuYGOq6--w@mail.gmail.com>
References: 
 <CAG+FJqOxYj=sVyHcys64h9DbvzP6EUPGHJ7oKj-PW=Qp5Ebk_g@mail.gmail.com>
 <3574719.1784140144@sss.pgh.pa.us>
 <CAG+FJqN84B4KjmMp2oR2wSJUiEbgG1SV78wncUmi2Cz1qvDUOA@mail.gmail.com>
 <3577449.1784142765@sss.pgh.pa.us>
 <CAG+FJqMUxTXMhFrShEfygnONTS-_yBJYwabwWS0G26hNDfv+DA@mail.gmail.com>
 <3789751.1784217864@sss.pgh.pa.us>
 <CAG+FJqNpLQZ5uc321W8oC7M8VzGmuJQx6vCkzrxHzuYGOq6--w@mail.gmail.com>
Comments: In-reply-to Maaz Syed Adeeb <maaz.adeeb@gmail.com>
	message dated "Fri, 17 Jul 2026 09:32:10 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3959546.1784310152.1@sss.pgh.pa.us>
Date: Fri, 17 Jul 2026 13:42:32 -0400
Message-ID: <3959547.1784310152@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3959547.1784310152%40sss.pgh.pa.us>
Precedence: bulk

Maaz Syed Adeeb <maaz.adeeb@gmail.com> writes:
>> Thanks.  index_including.sql embodies all sorts of anti-patterns
>> for testing: use of very generic object names that could conflict
>> with concurrent test scripts, constant dropping and re-creation
>> of objects ensuring that the overhead per useful test is as high
>> as possible, etc.

> Thanks for pushing it. This one seems like another nice opportunity to
> clean up testing anti-patterns. Apart from the two mentioned, are there any
> other anti patterns here?

The other thing that was irking me was that it numbers all the test
cases.  That doesn't add any value, and what it does do is push
authors of new test cases very hard towards "add at the end", whether
or not that's the most sensible place for them in the overall
organization of the test script.

			regards, tom lane