From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jchampion@timescale.com>
cc: heath.lord@crunchydata.com, Daniel Gustafsson <daniel@yesql.se>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than
 PG14 when SSL is not in use for the connection
In-reply-to: 
 <CAAWbhmhYNOubS2qTx3rG8V2STZ9F0SrtRBuPJimCwRYAQ6r3BQ@mail.gmail.com>
References: <17625-fc47c78b7d71b534@postgresql.org>
 <346263.1664480998@sss.pgh.pa.us> <360379.1664482591@sss.pgh.pa.us>
 <CAAWbhmhYNOubS2qTx3rG8V2STZ9F0SrtRBuPJimCwRYAQ6r3BQ@mail.gmail.com>
Comments: In-reply-to Jacob Champion <jchampion@timescale.com>
	message dated "Thu, 29 Sep 2022 13:40:09 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <395955.1664484332.1@sss.pgh.pa.us>
Date: Thu, 29 Sep 2022 16:45:32 -0400
Message-ID: <395956.1664484332@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/395956.1664484332%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <jchampion@timescale.com> writes:
> On Thu, Sep 29, 2022 at 1:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This'd still be broken for the
>> multiple-libraries scenario, but I admit that that's pretty
>> hypothetical.

> Since the goal is to let clients decide which connection options to
> hardcode based on the SSL implementation, I think it stays
> forward-compatible with multiple libraries, as long as this API
> returns the "default" library that you get if you're an older,
> clueless client. We would need a new API of some sort to let newer
> clients figure out their choices.

Yeah, that was in my mind too: we could leave it like this as long
as we define the result for (NULL, "library") as being the default
SSL library choice.  Good enough for now, then.

I'll go tweak the documentation as per Daniel's thoughts and push.

			regards, tom lane