From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: xinwen@stu.scu.edu.cn, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17826: An assert failed in /src/backend/optimizer/util/var.c
In-reply-to: 
 <CAApHDvoKryODcxkGGHihK6q_d-_09mQJqCwnVv6pjLM4xU3R2Q@mail.gmail.com>
References: <17826-7d8750952f19a5f5@postgresql.org>
 <402866.1678378153@sss.pgh.pa.us>
 <CAApHDvoGAu9rY4iO0R+DZVxPck_M3015WUL_34XOhi9ygxYfnA@mail.gmail.com>
 <1229467.1678555436@sss.pgh.pa.us>
 <CAApHDvoaExj=YiOJ4PpbshPnOV5d95HQAGJeh44HPQW6Nns-8A@mail.gmail.com>
 <1616392.1678657435@sss.pgh.pa.us>
 <CAApHDvoKryODcxkGGHihK6q_d-_09mQJqCwnVv6pjLM4xU3R2Q@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Wed, 15 Mar 2023 00:13:41 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3962533.1678993174.1@sss.pgh.pa.us>
Date: Thu, 16 Mar 2023 14:59:34 -0400
Message-ID: <3962534.1678993174@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3962534.1678993174%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> On Mon, 13 Mar 2023 at 10:43, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Ah, got it.  So basically, the quals that we want are excluded by
>> check_output_expressions' point 4 (since they reference window
>> function output columns rather than partitioning columns).  I think
>> we need them to satisfy every other property that's checked in this
>> code, though.  Now I agree that we need to refactor a bit -- we
>> don't want to have to re-check all of these conditions.

> OK, patch attached.

This looks good to me.  As a matter of style, I'd capitalize the
enum constant names, but I think it's OK otherwise.

> I probably need to do a bit more indenting work.  I'll look again tomorrow.

Yeah, this looks like pgindent might not like it as-is.

			regards, tom lane