From: Tom Lane <tgl@sss.pgh.pa.us>
To: higuchi.daisuke@fujitsu.com
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17681: Building the REL_12_13 source in Visual Studio 2013
 fails.
In-reply-to: <17681-485ba2ec13e7f392@postgresql.org>
References: <17681-485ba2ec13e7f392@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Wed, 09 Nov 2022 06:08:36 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3969639.1668005050.1@sss.pgh.pa.us>
Date: Wed, 09 Nov 2022 09:44:10 -0500
Message-ID: <3969640.1668005050@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3969640.1668005050%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> I tried to build using the codes of REL_12_13 in the following environment,
> but it failed.
> The main messages when it fails are following:
> -----------------------------------
> "Z:\postgres\postgres.vcxproj" (default target) (2) ->
> (Link target) ->
>   snprintf.obj : error LNK2019: unresolved external symbol snprintf
> referenced in function pg_strfromd [Z:\postgres\postgres.vcxproj]

Ugh.

> I think the cause of this error is the following commit regarding
> snprintf.
> As a test, I reverted this commit and built again, and the build
> succeeded.
> d33ac1ec2af5297b2ac8fbf89464f0c7f90a7955

Thanks for checking that.  However, as that commit message says,
we require C99 support in v12 and up, and snprintf is definitely
required by C99.  So I'm disinclined to revert that.  If VS2013
can't supply snprintf, it's not meeting our minimum platform
standards, so we should remove it from the list of supported
platforms.

Having said that, Microsoft had had well over a dozen years by
that point to get off their duffs and build a C99-compliant
library.  So I have to suspect that there is a snprintf lurking
somewhere --- maybe there is some build option you need to
enable to get it?

			regards, tom lane