Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1qhh83-003vGx-VZ
	for pgsql-bugs@arkaria.postgresql.org; Sun, 17 Sep 2023 02:03:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1qhh82-002JnL-BN
	for pgsql-bugs@arkaria.postgresql.org; Sun, 17 Sep 2023 02:03:18 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qhh82-002Jn1-1Z
	for pgsql-bugs@lists.postgresql.org; Sun, 17 Sep 2023 02:03:18 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1qhh7w-005aXB-HG
	for pgsql-bugs@lists.postgresql.org; Sun, 17 Sep 2023 02:03:17 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 38H23AZP3998851;
	Sat, 16 Sep 2023 22:03:10 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18070: Assertion failed when processing error from plpy's
 iterator
In-reply-to: <ZQZbbPA7NC5A0f4i@paquier.xyz>
References: <18070-ab9c171cbf4ebb0f@postgresql.org>
 <9fa9c154-d084-07de-8224-aab7fc8a119e@gmail.com>
 <ZQVm8KponTxqj8G3@paquier.xyz> <3920993.1694874885@sss.pgh.pa.us>
 <5eba3ea5-ae13-aab2-35d6-cd3e58dab08b@gmail.com>
 <ZQY/Nfv20tt4PBzA@paquier.xyz> <3984911.1694908923@sss.pgh.pa.us>
 <ZQZbbPA7NC5A0f4i@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sun, 17 Sep 2023 10:50:36 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3998849.1694916190.1@sss.pgh.pa.us>
Date: Sat, 16 Sep 2023 22:03:10 -0400
Message-ID: <3998850.1694916190@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/3998850.1694916190%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Please find attached a proposal of patch for a backpatch, that applies
> on HEAD.  The backpatch needs a few tweaks for alternate outputs, of
> course, depending on the version of python.

Yeah, the alternate output files will be a bit of a pain, but
should be straightforward as long as you're paying attention.

My only suggestion is that

+  plan = plpy.prepare("SELECT to_date('DD', 'DD') d")
+...
+DETAIL:  spiexceptions.InvalidDatetimeFormat: invalid value "DD" for "DD"

seems unnecessarily ambiguous, and so confusing as to whether the error
message is correct.  Let's make the input string be something other
than 'DD' here.

			regards, tom lane