Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLMd4-00000001TEk-3iZL for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Oct 2026 15:28:55 +0000 Received: from localhost ([127.0.0.1]:60100 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xLMd4-00000006FM5-1nyI for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Oct 2026 15:28:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:44438) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLMbD-000000068f9-18du for pgsql-bugs@lists.postgresql.org; Mon, 26 Oct 2026 15:26:59 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xLMbA-0000000155p-3fCP for pgsql-bugs@lists.postgresql.org; Mon, 26 Oct 2026 15:26:58 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-c4550d8ab15so396797466b.2 for ; Mon, 26 Oct 2026 08:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=planetscale.com; s=google; t=1793028416; x=1793633216; darn=lists.postgresql.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=forYxcvwO22Ey9COGKlupg4MtizsT6ib4q/p734tAfM=; b=Athxq2VWxUiDTI+PWN6+Jr/BQR8XE7BIA3LMJjInZ1Ny02ef0BbvKVg1zG5/MN/1wd ZfNBhsloqlsUtQU2zdcdoBNstGwm6WHgu9OihK9bZ2xuAU5i3L1Nru8P/mbpFbSDxY/Q vUZUbEcfHHgTr/gjl67TFpmU1LBo0YrR2LFt1HnFrfNHHRmZoLqbEkmkMSi0YCALdBzh 41asER4clIQVDbEFBbpvrsev8s6srxlaUxX63BpxdnTkoBBGK7lyZn8lv+IUHA70DV0S mdB3xoLS8ym612riWHBfZou/EHuii2IAYu7LWUFNMyRYr3P0BM39is0OnLqAhOVopdKM LfNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793028416; x=1793633216; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=forYxcvwO22Ey9COGKlupg4MtizsT6ib4q/p734tAfM=; b=d02WUSrVFg+RkjgvmvMN8VyZuvefgSoV5m3LbPhHSGkGhexDQ1tzQ/U2wHT7NQC6d6 /3aayau4tCBUqBNqtRkhS6YBFJEJzoO/iuAyqyCljda8L3PMig5QQTdZYAD0BGsw4UvH oREB5z3AksM1otXuu5C+tVyRVvQ3XQRFl9wXDOoAe+y1AqiD8Mpbo37hR5G8HFyhXjGw vMFCSpnLgrDhpNr2C0gT1CqLKnuWBxoZ7CLntnlAH6YXQWZ0SmSaT349vi/EGoDV+47a qNdrMxpR6mZGK6gJ0CyuGxDpIl9gV9mpGzxNqU/7Ba+mRgC3YV3ZZg1ENMaSpslpMVWo DqFA== X-Forwarded-Encrypted: i=1; AKwUvBw6qSF1M5c+3hANp9/H+croLsipfWQmbK/lXYMTtBUAFsNN77FA36P9IzBIMXjqfVG/o7WQy0doUtA4@lists.postgresql.org X-Gm-Message-State: AFq9FYLapGP9q2QQzD53NdbD72w/DbPiut9dySauD9AfHTeUU7T17lVC EChdos01JvWp+Lm6nDrVBbSpEkPyftnRYRStOE17uhaIvucPmYUqzuI8kSHkBjES2P2KtMBtF8/ x5P6TLj0= X-Gm-Gg: AYBFou1pRBqMjCu4ZdgL1PDOe98q7lLI1KZ4VpJdoCw/LFe9HMAjiH9ax/1bC/YU6Yg RtLXFUUxv21j1inZi2EmcypFEGREe7I6yiBwcKCr3SgfVBQQpYUG75OdEfJoH68TZrLcMmrf4DA IXhrxIDBiWpKR6q8wwAFXjbbONEZvKdpvfJIQfOZHjalXSOmy61zyuDY32z7Jjqqnl1TBu6ZLWY rMsh9zv93O1y4b4iPtxf7fkmCVLNgXqnIz2bP8T7v8fNhbSILJqQWAqG1uLCOO2mkFyMR/VjdHl gzdN7dk2hhH7JsAorV8cksVt1Inm4kG2uk7XKVXfo/bKcli1HP1KMH3X+aAXfClT06MRsYidTW8 /5PamgD9+6C4tJ5oIjpjnzc+SQWDF7mdp1M1WEdNT1nmoEYG0DPuc5K26BDC50JSLTU8ILboHSk kGr28vrLIG2unDMbDcHZHHqqCP4QagLJPuJ+au3yXWh8wXWcV3WxEcH9o2CT3b1rom7Y/5KR86a x8uTVVM06tmtUgr6xz7gCqbHzrpt4rbpKwEzKFkZni1WL/DL2+/kLo6nBcqPQkVZbyCOptl29ja 9bCL6CVUFTnxg/K5cHXw+2AOTeEWoto53iD+ofQCkJnSZG7gBchV X-Received: by 2002:a17:907:7b9e:b0:c41:b94c:4538 with SMTP id a640c23a62f3a-c46bdec03f8mr883430966b.47.1793028415881; Mon, 26 Oct 2026 08:26:55 -0700 (PDT) Received: from ?IPV6:2a04:4540:653e:2200:9104:f8fd:70f1:c2fe? ([2a04:4540:653e:2200:9104:f8fd:70f1:c2fe]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c46bd350b52sm330488966b.7.2026.10.26.08.26.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2026 08:26:55 -0700 (PDT) Message-ID: <39e2b3b2-aa68-4e8d-832e-6e3904e9bea7@planetscale.com> Date: Mon, 26 Oct 2026 16:26:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: START_REPLICATION silently truncates an overlong LSN component To: "Hayato Kuroda (Fujitsu)" , 'Fujii Masao' Cc: Ayush Tiwari , =?UTF-8?B?4pmCz4DiiYwyNjIx?= =?UTF-8?Q?8?= <1991230470@qq.com>, pgsql-bugs References: <8b1abbd0-7335-4e68-93ec-91cdbbfd9568@planetscale.com> Content-Language: en-GB From: Jan Nidzwetzki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Kuroda-san, Fujii-san, Thanks for updating the patch set. I tested the two remaining ones on my system. They apply cleanly and check-world passes. Patch 0001 ========== I have just a small comment on the moved MAXPG_LSNLEN. It's currently a hard-coded 17. It could make sense to export MAXPG_LSNCOMPONENT as well and define MAXPG_LSNLEN as (2 * MAXPG_LSNCOMPONENT + 1), which would document where the value comes from. Patch 0002 ========== Kuroda-san wrote in the v5 mail: > I also attached the test code to check invalid strings can be rejected, see 0002. > I'm not intended to be pushed. I think this test is worth committing. As far as I can see, nothing else covers the "this is an incremental backup, not a data directory" error, and the new LSN checks would otherwise remain untested. However, we test only an overlong high component. It could make sense to add this test for the low component as well (e.g., using 0/123456789). Best regards Jan -- Jan Nidzwetzki PlanetScale Postgres Core Team