From: Daniel Gustafsson <daniel@yesql.se>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: BUG #19457: RE:  pgp_sym_encrypt silently accepts non-FIPS
 ciphers (bf, cast5, 3des) when OpenSSL is in FIPS mod
Date: Tue, 21 Apr 2026 16:04:40 +0200
References: <19457-4bab15c17aea36c7@postgresql.org>
To: ansh01072001@gmail.com,
 pgsql-bugs@lists.postgresql.org
In-Reply-To: <19457-4bab15c17aea36c7@postgresql.org>
Message-Id: <3A2299BC-1684-4CEB-BD65-1DEBFB446F24@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/3A2299BC-1684-4CEB-BD65-1DEBFB446F24%40yesql.se>
Precedence: bulk

> On 17 Apr 2026, at 06:21, PG Bug reporting form =
<noreply@postgresql.org> wrote:

> I am happy to work on this.

Please do, that would be great.  I'd be happy to review this so keep me =
CC'd.

> Add a FIPS cipher check in pgp_load_cipher() in =
contrib/pgcrypto/pgp.c.
> This function is the single chokepoint for all PGP cipher operations
> (encrypt, decrypt, session key encryption/decryption). A whitelist of
> FIPS 140-2/140-3 approved ciphers for PGP use would be:
>=20
>   PGP_SYM_AES_128, PGP_SYM_AES_192, PGP_SYM_AES_256

Maybe an extra flag in the cipher_info struct?

> All other ciphers (PGP_SYM_BLOWFISH, PGP_SYM_CAST5, PGP_SYM_DES3,
> PGP_SYM_TWOFISH, etc.) should raise an error when CheckFIPSMode()
> returns true.

Not just FIPS, it should check CheckBuiltinCryptoMode() to be consistent =
with
the other builtin checks.

--
Daniel Gustafsson