Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLehi-00016b-8r for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2020 03:15:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jLehh-0007jn-4b for pgsql-bugs@arkaria.postgresql.org; Tue, 07 Apr 2020 03:15:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLehg-0007jd-Ur; Tue, 07 Apr 2020 03:15:08 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLehe-0006Qo-2U; Tue, 07 Apr 2020 03:15:07 +0000 Received: from hnk.local (p2421237-ipbf2725funabasi.chiba.ocn.ne.jp [122.24.33.237]) by oss.nttdata.com (Postfix) with ESMTPSA id 7AF93602FB; Tue, 7 Apr 2020 12:15:01 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.2 at oss.nttdata.com Subject: Re: Don't try fetching future segment of a TLI. To: David Steele , Pavel Suderevsky Cc: Kyotaro Horiguchi , pgsql-hackers@lists.postgresql.org, pgsql-bugs@lists.postgresql.org References: <16159-f5a34a3a04dc67e0@postgresql.org> <20191212.124856.202839248708529678.horikyota.ntt@gmail.com> <20200129.120222.1476610231001551715.horikyota.ntt@gmail.com> <8c831a30-a3a2-de89-2059-e7ce842d7aed@pgmasters.net> <792ea085-95c4-bca0-ae82-47fdc80e146d@oss.nttdata.com> <762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net> From: Fujii Masao Message-ID: <3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com> Date: Tue, 7 Apr 2020 12:15:00 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <762ffb60-df9c-0efc-2714-9859219157e3@pgmasters.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020/04/07 4:04, David Steele wrote: > On 4/6/20 1:43 PM, Fujii Masao wrote: >> >> >> On 2020/03/19 22:22, Pavel Suderevsky wrote: >>> Hi, >>> >>> I've tested patch provided by Kyotaro and do confirm it fixes the issue. >> >> The patch looks good to me. Attached is the updated version of the patch. >> I updated only comments. >> >> Barring any objection, I will commit this patch. > > The patch looks good to me. > >>> Any chance it will be merged to one of the next minor releases? >> >> This doesn't seem a bug, so I'm thinking to merge this to next *major* >> version release, i.e., v13. > > Not a bug, perhaps, but I think we do consider back-patching performance problems. The rise in S3 usage has just exposed how poorly this performed code in high-latency environments. I understood the situation and am fine to back-patch that. But I'm not sure if it's fair to do that. Maybe we need to hear more opinions about this? OTOH, feature freeze for v13 is today, so what about committing the patch in v13 at first, and then doing the back-patch after hearing opinions and receiving many +1? Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION