Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeMff-0001R5-Pi for pgsql-bugs@arkaria.postgresql.org; Thu, 28 May 2020 17:50:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jeMfe-0007BL-LX for pgsql-bugs@arkaria.postgresql.org; Thu, 28 May 2020 17:50:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeMfe-0007BE-AW for pgsql-bugs@lists.postgresql.org; Thu, 28 May 2020 17:50:22 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jeMfc-0006wj-5W for pgsql-bugs@lists.postgresql.org; Thu, 28 May 2020 17:50:21 +0000 Received: by mail-qt1-x842.google.com with SMTP id e16so801829qtg.0 for ; Thu, 28 May 2020 10:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joeconway.com; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to; bh=sOk4IKz6PzIX+HTVB1BGHx11HhATt1fB12POMnNmePI=; b=rnGHOV0a0Z/iVI8J7MN52Pf2XkBMvf9+TbGllciepz8FWG9coBCDcz8CBWMuryOf4M nFYIMdITaCIVkCSTToJjMJdME8gOkCydqfkYunyI0G+BIClKZomVLsE9HibvBYiqo2a1 8RkQTCefoUIzpCimScU72s5AwSg69WKB7tK70xx4dABGPrEx0dIt1FNAfzfM9b6Evg8U BjMqrQxepLnW6/7aHhgt1vtCxn0bYs6UEOVkyX6Pk56573YjAmwbqgVLQ3sIs/lr5zKS L8hzrsgkFWOonUoClXiUjklCmzPm8NeN/z7YdHUhFThwln0kkY955ayb/UqVwvTNUCel rVXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to; bh=sOk4IKz6PzIX+HTVB1BGHx11HhATt1fB12POMnNmePI=; b=AcQfxBG410DcqnoHMzV5Buy0LiILFYS2avzMMb+c3T5ABi0sQTwgSIhPykshIpVndZ iq5GbDTb8AkILDe62LQXEfhKJOmcA8RsXe863t1AuSqFcB8z4aH4Td53TWr8rvD2W1ER 6xnSSjtSMV83tIwwaxjw2m1MFewUjJtXllxOtvDpATb8eorSBQHRUl9LULZY0P2WkT65 ybZftGYEy9QyOOxZf1WPtjdArHt1R8lqP5EWzqEstC+vOtFZuFWOvdUBfsXcqKubg0kc u/EoeVZSWliO3FxQtrMOkDIX/VTzKQOl3ealu6PLLagvfYOHVmyCI45yG+ZT69QBqaZm 8+wQ== X-Gm-Message-State: AOAM532qHh84mOX/0enJ4Z4LNQsKhJUyyblEbpo7Ok2ujbyy1IjX4s19 PXojDuzXTjP6gofqXsXyhPgCflz3SfURYssqywXze7R5aodxhtt8pEcLm8nj/BXwzPg40v1CFCA AYt1xAzuR7ROWOWcmNt66w2Cskh9YhXVE1jEZ+NxQ4CP7rWJPvS3UEPGBaKdU0HI8Y+aPPz/mWv ci7QU+ X-Google-Smtp-Source: ABdhPJwNyWra9mKkdo66PkfHwpv7h+fPJiPgbNwaMyFLn78OXEDAYwBmd3yWy0O5YdGRuYdgNLgmrg== X-Received: by 2002:ac8:7c8e:: with SMTP id y14mr4481214qtv.112.1590688218359; Thu, 28 May 2020 10:50:18 -0700 (PDT) Received: from [192.168.4.41] ([72.17.18.98]) by smtp.gmail.com with ESMTPSA id i94sm5626299qtd.2.2020.05.28.10.50.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2020 10:50:17 -0700 (PDT) Subject: Re: BUG #16466: Valgrind detects an invalid read in dblink_open() with a cursor inside a transaction To: Alexander Lakhin , pgsql-bugs@lists.postgresql.org References: <16466-09cfa4a5a0e72cce@postgresql.org> <9bd0744f-5f04-c778-c5b3-809efe9c30c7@joeconway.com> From: Joe Conway Autocrypt: addr=mail@joeconway.com; keydata= xsFNBEpXMCsBEADDnXUQzjlyi/cX02Gtdy2CLcroE5CsC7DJKdOBDbfgn0kfiIYoV5JniG4l VyzZUodY8yUAagqLYolh0UkBzs9N+qkm7erde4ypw3jzVQ37BuzIvk3nMUbuDZDgxWqX+nVS sKc+BQ5BpzgCHg48leoRO2ohjvYnUhgH3j2rFZCzaj6qQ7mv+XoxOJmUlVQtG06Jwkk7Vu14 7U9nMMM6hyUKzVnmCphnlcMNo26UyVU70MwFfFJgcI0c5fpp8byN56eD6VJVnufO5WAuEhzE qcrSJR2FAlmM90GBY+6vP29twLDCHuSFvrnujNCx/BvCC/a3/gPvyAFp4JtMm9eXAmq3m/Kw 94nTJXVdcbQeQQDp3KIG7MmWS4lnGvPn8v0CjgNaLvZXFLo1FgmUVsyEq1Lww4iRLa6sbpXJ ESx15UEue1k1YZM9C+4F/o3aeKNsAienjw2EXFzcaxIg/C4P493VMi3Qa8ycVxR5iYhUbYdo DFIUQhbFNsYfrtW/qZAELT3FCYFpZYG01e9Hj+cBrXXgyDDkQ5Lq4mlvmkRvuxn61V6Au4HA 0sJiCox5pM1FvzT+aI8HY1BYaiB9Pl4fhpKgmhhlSuglk9v39S4jmlUIb45iLAUVpeNM6Qjm 69pf5da9sm4aGFa7YlDSKf/WcU7z9ITZxsilOi2n7YJiwG7kTQARAQABzR9Kb2UgQ29ud2F5 IDxtYWlsQGpvZWNvbndheS5jb20+wsF8BBMBAgAmAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwEC HgECF4AFAlpoksUCGQEACgkQMyt+aLaZQ0p4XQ/9F4WSf4ZFuL3ae356ApVqnLxphHXeXHli ePZe7qosvXMQLN9Y2m5cQwqojsQh4pZujIi4Iwxw7ORg6HbMO8dMhyu8TlDavErcgO561hG7 /TCcCLf5SkadxBqYWAJH09W8S2iC3gQtS+qs4Y7sIvRi881EsPzG5Lrzu7Ei8ufqsSnbLUQk zAaKjK3IzAFvzA3VCg/8Aqhf8obhqL0j5I5DNOpAt2U4gkEzIrX1g5xSXpRLMHLEK7hPViY8 pFQyRvyZioE4hckNsnidCgiv4HefJUFRIVxDkHBeLhTzqTPloesFT/bskhckIS6F4suMx044 WTTW6UiARuWw3aaBTmxay2rjPCsGaJPawzY0O3HlNlZherCzuBpa+Qk1kMLkcxMlYjCrMgIR YyBpIK46ltPQaog4Ujh21w1Z8m/ufG5v/HTuLdXM9hGfTlW7aY6psCAV/MwfycDHLRMc+UY7 W2cp6DlWQ7GHLP+vzvBcl5Odi04EhcYnHMZjKvRFsxhE0LZcTejrtxPkDgR9G59irlIx1+py ziK2B0hs7Er1Yq7qQGQiQGLoglSNDsvsUeyMGyabasmUd5xrRO35SpGv+hyYGAZ3Pyk9Vtxl CO7BJkZiV9YSMHp6hOdmYZd4SZRChd9sKd6eSw1xIlBALz1ZHuQVMBuZvuVGFsS81Zqckb/2 D5rOwU0ESlcx7QEQAKhm5UhGfbe3hM4yCaa/pPaNaswlB2tK1DHAjDlDm7gDVEodfsrvAFUU unLodlvCd0g/GpLmXXdROU/I+HusVqQhDbVeHMwO2VUVHamRWqDfrCjMYVxLz80d96TYyeyW 6RUNkJmXJAOKgy8veI7Z1F+j1gXQR7UlzonnSkWbs0oQ3RglvyqhkUzWtXU7F+j2hQ2vQsct Lnq3lYo0bYkZ3K6RyKZXSly9Hd7DzYkMzz7StNRlyeQJxplPrVPup7N8SqDrI126sq0cwdUB Gn1sKVoO+bGidBjhJgxouNPkMJlPjbKOgb7tv5ZnM33FGXNdC5sPKoZ4mC+gaqRHYaH/V61v fCo1CYNLIK+Cj+Oua8mQ6CPeOb5VKcJ0JM96eGNlzF9EawppOG7xCDcbmBEr0m1go9MHEUel 0L1i8RSDYOHQQkLT2MVWYf4UsRlEGbME+kF7DEX9Fvie7qglFTXC2d+YVN73AnXcoM/IYUOR DXjVVaqQoHuA4uxwJ31o/rEaOihr2yCScr8mB8J3b3KyNfuCBm5gN0tUQw+t5szMYurDpZ1G L4O7btaQ5u4iJMfRTCnPrzW+wkdVrao7AmRNWEtSlXsycClKFCHz/Ej5rpXOKSp+a/xcaFX1 v2eS/+Ujp5ESu9p57JwlP6aSqYBiOALRJXZ9DVtZL96okjzXjrd7ABEBAAHCw34EGAEIAAkF AkpXMe0CGwICKQkQMyt+aLaZQ0rBXSAEGQEIAAYFAkpXMe0ACgkQN/L3QzX32GV1Jw//fhvL Mk1YNS/2N5jc5HYmEjcL2OWBLLrO5RMCaOgCNmYsepkigy2U+GSloVy8Y40/UfYzIoNf1DiB Qyj5Ipa4eMjfKA7+1q43a5wkDDWogFNflKTTNemwrHDKR1WWDrxt8uAgJdlBGDQA7A0q3D2i Xhd7ALLOHhuXDY1++N9TK9KMfV90Oay0mIMLQhTG/UgsgrYYb78H2pk8XMYZY29vgZlj9VH2 f1RpOoh7lCaB+2glN27Rzh17q0/zEjwXk4sDyYHRIycaqnM4ozSnliXyoWM5bvmqSGBCm5jl BjNW+cFbFy15U595AIXXiUXl8hsTF2JWwgHr+hYdtoEH3oEOxzM18ENXKTTgN+BafdMsah4e HIcVvrVrH6rlsPwCvk3o/PJ07qVbUW+dbZG8UB1JwqUUqGhrCk87kztajlvZGZWxWDSB4Lnb T6Jc0L7/YXG8U3sJ2OtZ95Lal5XfNo0yBdPflmalH3xf/EcxaYFETbDrY5UgEVa2HBw8XzKk rTbM8rD318M+jBOuL6o3cGMOeFOm4C51fJZmOCFd03LhMkoj9IbLIPGKosIBsxb7zP5YLAbI b3el6pvo9CKtNuR+IcVOoFtH+KVOxGsbbxFEFbsAmPMreF1hIv+l+HXBaDhUkaUmpJ1Mhxol aM6O/LGG4VQV7wBQFunVaN8EPqMqYDph3A//TjQVd8fqvw5Ezj1958IUmV0jxeGX2m/fspGh njF+6Adx3PFbZoKyW71cA/TnlHVYCaizjYYRNMC3g5VFytOYOZFi0GKsxQTX5PcPhDjFFTUv FVVZwDYUK3QlC+wGDTeNWfAJIZnTPPIXSiHzh3si+ngKjE+ngcRF1VY5K4xvc6ss6uq8kI8L Ct+TpOMr99ijaYEbMZ8WJagynD5BLNYxpP6CCTMDi1Xqydg0E/mhR9w9aUOvdTZw1OOKtLnz B1E0wFbzJXEvjP2eEVNlStS5RTawFDpqxGwXJcHqe8qtg8B+C1r47RmHnKKm+DTOPFQWTj83 l775aNMzAHm+Pr1TdSA5XRyQ3wxwYKfhp1suKhILUZLjbiCQf92RZQ6yEdXskMr2A4n0GQWq Q8k7r9QPqtUP7lsiyyDem7r9h5mAm94r3Td22L3JaSHkBD+4jC4gIXeYoyd+lTz/zYOx0Fri J8dXHalmyTGsSxV7FXv1/thVEf6R7TDdVwhqf/WL3uWTmVBR0tJscG+9iCVch/OG/uCDkWZQ sOTotqj6f5jSZI+NOUqt62+8i8gjYEa7zRZ2HXFOTV8UduCjheWB2VCUj5EjFjTMjfTVkyZ5 SiFht7bM5l/odoYU6vn37/5s/ZsMTZX1zG5oXv6iULrHLYHhUxR93FlVyn4DiHsWND/Idj7O wU0ESlcyJwEQAOkTBb9yDhJbMUgvhM11rZwT5tm4Y9TqtEHn0Zy3t9g7bdFFpMvav/KENd3o AtLFpMDf+H3AggFk4ftUwJwiVgJ88ilvCynJUGXiuYIaexY4DLgn4xpnuiEpYEFVdWnlw7dW VTc62exfqIz9bSWRzwfBCY9ruYGEb4RDPDSNSAVyI7sxHzef2asiYxIcxrTrw5VugWNlPZcV 5/EJ6PUvATjBF2TBkXV7KOciQng2tsQGrGMkY5mduNqwpuh6zfPcVF8LeObe96wv5ZhPRpO7 9nef7hnK2lJogp3JIo558Jlbz9WHtQEMZR85+bUhtI825QyNAFz3Jrn7NMgvDikc2OrWo7YM gMC5hDSWVFqA6/EQCNnDWGABWgeYHZFpnPwsvUWIYdhSilUuj/Tuzvz9ZmucFNbQbauDQw6V Q38ofGnoYDZFJsGncprB8dBi4tDrIQ+1RlIh6C2Z/eMipqJOT26+spluTjouvnKT0S5yOgyX 0PjbsysgwQdCGNJLHOjhHbSpSmOLaduV3CQo/0+DHT/TBjYfIXjTWouY9TkGxG4eNrxU0u2x Ay5bMqOPmsFdjLTWlQUlF/fTMhB54XwI3FHWgnSnXZzStDTmTebLNdT/ftgliAzA81uMj49j 0exv731/v+7udLA1bV8gnZ01zQCASDpWiRQR3fgwcugSUqgRABEBAAHCwV8EGAEIAAkFAkpX MicCGwwACgkQMyt+aLaZQ0pwAQ//bjcWnZg/jjRQ9gbZUGMqniItZYRglBMKIqt4Fia379Jm HwTvavnFkJ8XMZ56UB0FIrgS+sUkRH6cPRQR+7Qi392LD021DXgSsz9CwFHjFyBGHwLEOTRc fYQbtJy0shHDJB4aQTOX3ERDH1PsvJNuevmQMzS0DWFav9+xMz9rKP4N+HffoBIZE0C1xIE4 3nD4eLsbycte9sVIrmlNuUti3qUxJAQw8HwfJ6ZbBInHxquApR16uD1u99o6XlndFrDlY22t RmHCM0bR81GfGNdcU3Uo+rG/R/k4qa7s9/dgKvMbyH3fHhp/ceKag80Xo8IFurRl0ZJP3sHJ 2QDHCVLat7jRZ+43hi1WlIhFbrgn6IyI0i7XR/W8JjrC5MsKq4TUwGH077sU/kcHYebVJZRb UUst2hAGHDFVBcG12qoKf+ltL9qXJc1y7BGeCoUW6QjOpljpq6ZL4FQUsM0RSRjs5egE3szP cIf5SyPK6WDOApoAq6M7BBFMGDZwEylYMtr0YekA1u86UA9D2xwLHEbBBp/uiby1c9JbPJ1P n8zJP8WZNeRw4Q9TtqVK09+oLirMUSpIDd6KdZ1VgRxOK2re7tjDvkVuYsSrsiJ+1iJNEnp9 iK0ok0DlJpSCe6KhkxpaTdeoWMXdKuJWec0NIqoAd54ZgBPnr+UPxTixgPq/p6Q= Message-ID: <3e6699ba-3896-a641-0c95-b64069d77a73@joeconway.com> Date: Thu, 28 May 2020 13:50:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5VvFumzp68YvijxiSiBgsGYR45MYEvs4D" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5VvFumzp68YvijxiSiBgsGYR45MYEvs4D Content-Type: multipart/mixed; boundary="ivJgiB84eRwbr1g9f0Dg0hYjethycsGGW" --ivJgiB84eRwbr1g9f0Dg0hYjethycsGGW Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/27/20 5:00 PM, Alexander Lakhin wrote: > Hello Joe, >=20 > 27.05.2020 22:58, Joe Conway wrote: >> Hmmm, looks like a couple of the members of rconn are left uninitializ= ed. >> >> When dblink_open() is called *without* an outer transaction it handles= the >> initialization for us, but *with* an outer transaction it does not :-(= >> >> I think the attached fixes it. > Yes, your patch makes valgrind silent. > Thanks! Thanks for checking! Pushed to all supported branches. Joe --=20 Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure Enterprises Consulting, Training, & Open Source Development --ivJgiB84eRwbr1g9f0Dg0hYjethycsGGW-- --5VvFumzp68YvijxiSiBgsGYR45MYEvs4D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEg14x9eymXoJyHrH+N/L3QzX32GUFAl7P+dcACgkQN/L3QzX3 2GUYNg/+NzVbOTud9lUXNS7OXpkXh3uXIQL6CA0uyNLlgTJ7jV+anjLVYY1T33rn Oc4inXSDClEfJyTfFY2rBEuJbzOZ2g742FF/iWsG4IalTdtLDSZmWxjhyPnEhhtD i5BV7vo1FiMwK4XwvxHUNgMmEx4IiJCDm0t1xROgSt/0AS5/AEMuL813J1vktEF6 fruX97pOSdRbNl9kSPz3xUYkC5SLfQIMXOBJgDjHNkWSGezvQDH5FyrqK4N5Djf8 bAiq532sI2CrvlmovTBncVBMkPnMeLH5j/nwwzuWYN4Ni47UNLIgM4fsPBDopBE/ h5TGExCxsj1L7NIf0NVTr7o28o8NN7Sq/QJGNQi4IdoyPkLHnN8uyEkxAf24J8O1 loZdR88nvrbN2PuYoDrBmmRljgfpa2SL4OURHGE9vJNvWfj5+p5nSCstOKt4p+W2 AzbUb7kn+WkDLHy1Pgj7GezuEu5c/KvPCSMlddmApaeLnW3ySGz9rzR89VS7BHpm T+shH9WoiBsI+Z97yzAxBeomVE2R0HhIj5RYc4q45sEZsDE7pWn2zUhk9eE14iJf MEWcF78jfhomIZ/78VixN3056QVCTmwNkzT2mT0JG9BIcvPN0QuJ23pazRL36ahj iLZa0D00Qc9xVm4psPHLDUzUWhJnjPVpI7Yr2UoxMRF5oeG1AJM= =dWX3 -----END PGP SIGNATURE----- --5VvFumzp68YvijxiSiBgsGYR45MYEvs4D--