Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKlTe-0000dA-IO for pgsql-bugs@arkaria.postgresql.org; Fri, 12 Mar 2021 17:21:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lKlTa-0005Bi-LG for pgsql-bugs@arkaria.postgresql.org; Fri, 12 Mar 2021 17:21:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKlTa-0005BX-FR for pgsql-bugs@lists.postgresql.org; Fri, 12 Mar 2021 17:21:26 +0000 Received: from relay13.mail.gandi.net ([217.70.178.233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKlTY-0005Dk-Ba for pgsql-bugs@lists.postgresql.org; Fri, 12 Mar 2021 17:21:26 +0000 Received: from [172.16.255.146] (14.149.88.79.rev.sfr.net [79.88.149.14]) (Authenticated sender: vik@postgresfriends.org) by relay13.mail.gandi.net (Postfix) with ESMTPSA id CAF7D80004; Fri, 12 Mar 2021 17:21:21 +0000 (UTC) Subject: Re: BUG #16913: GENERATED AS IDENTITY column nullability is affected by order of column properties To: Tom Lane , Amit Langote Cc: pavel.boev@invitae.com, PostgreSQL mailing lists References: <16913-3b5198410f67d8c6@postgresql.org> <7c02b352-a2e4-e71a-ae69-7e410daf5774@postgresfriends.org> <2441173.1615563048@sss.pgh.pa.us> From: Vik Fearing Message-ID: <3fb6c576-182e-e664-f64a-a65a74da85de@postgresfriends.org> Date: Fri, 12 Mar 2021 18:21:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2441173.1615563048@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/12/21 4:30 PM, Tom Lane wrote: > Amit Langote writes: >> On Thu, Mar 11, 2021 at 11:37 PM Vik Fearing wrote: >>> On 3/4/21 3:22 PM, Vik Fearing wrote: >>>> I can confirm this bug. Attached is a patch to prevent it. > >>> Would anybody like to take a look at this? > >> Patch looks reasonable to me. > > Will push it in a bit. Thanks, Tom. -- Vik Fearing