From: Tom Lane <tgl@sss.pgh.pa.us>
To: Miron Berlin <mironatpro@hotmail.com>
cc: "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: bug in function strtoint, on Windows OS won't report ERANGE
In-reply-to: 
 <DM4P223MB0518D09B523522F099A97E2CC0222@DM4P223MB0518.NAMP223.PROD.OUTLOOK.COM>
References: 
 <DM4P223MB0518D09B523522F099A97E2CC0222@DM4P223MB0518.NAMP223.PROD.OUTLOOK.COM>
Comments: In-reply-to Miron Berlin <mironatpro@hotmail.com>
	message dated "Tue, 05 Mar 2024 12:15:26 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4019548.1709653331.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 05 Mar 2024 10:42:11 -0500
Message-ID: <4019549.1709653331@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4019549.1709653331%40sss.pgh.pa.us>
Precedence: bulk

Miron Berlin <mironatpro@hotmail.com> writes:
> Functionstrtoint has a bug. It would not report ERANGE on Windows OS com=
piled with Microsoft Visual Studio compiler.

Have you actually tested that?  AFAICS, the code as given works
perfectly fine on platforms where long is the same width as int.
The lines

	if (val !=3D (int) val)
		errno =3D ERANGE;

are dead code then (and possibly will be elided by the compiler),
but it doesn't matter because then strtol can be expected to
set ERANGE properly for values outside the int range.

Possibly it'd be worth adding a comment to point this out.

			regards, tom lane