From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: =?utf-8?B?0K/RgNC+0YHQu9Cw0LIg0J/QsNGI0LjQvdGB0LrQuNC5?=
 <yarik97.6@gmail.com>,
        Postgres bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16927: Postgres can`t access WAL files
In-reply-to: <YFSMsxc8w2eqUHHR@paquier.xyz>
References: 
 <CADLmToKd=eFW9E+p7i0sxHOZZKshShvJSedD3ek=+PqhiXt4jg@mail.gmail.com>
 <YFMTgN8KY9MQsiIk@paquier.xyz>
 <CADLmTo+FaWQEi9Lt=f4kc9wL-XT+RiaEddW2kfuCZ=XiXycwNQ@mail.gmail.com>
 <CADLmTo+AOq2UE3Gr22omfcxhZajqkeGYgWFowKNScOZA1fWVFA@mail.gmail.com>
 <YFM2MRbHZGQ4DsG/@paquier.xyz>
 <CADLmToJJykdGUdKiPkut4mq8oZJ8z4+8d5aSUU9zCtey7yu_9g@mail.gmail.com>
 <YFPMl3TUPXbN127E@paquier.xyz>
 <CADLmTo+GoZ1tuyZxx5uprqSkwqqw3yajry36o-+=N=Jqe=0oZA@mail.gmail.com>
 <YFRglwF+j2RMmbXF@paquier.xyz>
 <CADLmTo+KJoh9+53=7UMfDQALzDEZWXYEUuv3k9YFT4Mo7+0NWQ@mail.gmail.com>
 <YFSMsxc8w2eqUHHR@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 19 Mar 2021 20:36:19 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4065518.1616166832.1@sss.pgh.pa.us>
Date: Fri, 19 Mar 2021 11:13:52 -0400
Message-ID: <4065519.1616166832@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4065519.1616166832%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> There was a typo in one of my previous messages.  What I was referring
> to is aaa3aedd.

Ah, I was just about to ask what the heck aaaef7a referred to.

Given the evidence that there's a problem, I agree with reverting
that.  I'd suggest keeping the cosmetic rename of the function,
but we have to put back the Windows-doesn't-HAVE_WORKING_LINK logic.

Grepping in the v12 branch, I find a second use of HAVE_WORKING_LINK
in contrib/pg_standby.  But that seems to be in a non-WIN32 code path,
so I don't think putting that back is necessary.

			regards, tom lane