Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oyc9f-0004xr-8p
	for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Nov 2022 17:06:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oyc9e-0005iD-0d
	for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Nov 2022 17:06:22 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oyc9d-0005i3-Nx
	for pgsql-hackers@lists.postgresql.org; Fri, 25 Nov 2022 17:06:21 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oyc9b-0006eC-D5
	for pgsql-hackers@postgresql.org; Fri, 25 Nov 2022 17:06:20 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2APH6FGx4066264;
	Fri, 25 Nov 2022 12:06:15 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Israel Barth Rubio <barthisrael@gmail.com>
cc: Yugo NAGATA <nagata@sraoss.co.jp>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers@postgresql.org,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Bruce Momjian <bruce@momjian.us>
Subject: Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same
 transaction with other commands
In-reply-to: 
 <CAO_rXXCqRiPLWjAKxP5P4RfTHWhwn-eo-uZeURib1umQSaEoag@mail.gmail.com>
References: <17434-d9f7a064ce2a88a3@postgresql.org>
 <3190751.1657845414@sss.pgh.pa.us>
 <CAKFQuwbY_vJWcvJLUz2r+zzwwhkJbjzjojfGx=Mvd9TZ0TTKew@mail.gmail.com>
 <3498921.1657919211@sss.pgh.pa.us>
 <CAKFQuwa9JQgKgg3Djrx=7p1Phhj68QEq0TWYG72Xv-nPz61r0w@mail.gmail.com>
 <805866.1658175624@sss.pgh.pa.us>
 <CAKFQuwYQpm6E4nTgiOZAGRg0JKquHaXQ0JkqruWeHuOQX6-70g@mail.gmail.com>
 <2350990.1658848101@sss.pgh.pa.us>
 <CAKFQuwYRYhF8iOD9MHp7VuZur_JvVEjDzpMHuUHNeYReB5v2Sw@mail.gmail.com>
 <2356216.1658849834@sss.pgh.pa.us>
 <CAKFQuwYxPhPVMGJ-uoV7rq291xAU3dwww2fWwMuaz6EPiruJ5g@mail.gmail.com>
 <2361330.1658851386@sss.pgh.pa.us>
 <CAKFQuwYaN+SJyHcXyjAwZ7zRCze+6Xj7ns_hOEg2+fhZEJUOHg@mail.gmail.com>
 <2363212.1658852059@sss.pgh.pa.us>
 <20220728105134.d5ce51dd756b3149e9b9c52c@sraoss.co.jp>
 <3214515.1658976655@sss.pgh.pa.us>
 <20220809002102.b815cd4dad20fdc91dff5ce8@sraoss.co.jp>
 <65a899dd-aebc-f667-1d0a-abb89ff3abf8@enterprisedb.com>
 <3995893.1668011885@sss.pgh.pa.us>
 <20221110144859.d9004fdd47396fe64fe032da@sr!
 aoss.co.jp> <229552.1668112417@sss.pgh.pa.us>
 <CAO_rXXCqRiPLWjAKxP5P4RfTHWhwn-eo-uZeURib1umQSaEoag@mail.gmail.com>
Comments: In-reply-to Israel Barth Rubio <barthisrael@gmail.com>
	message dated "Fri, 25 Nov 2022 12:17:02 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4066262.1669395975.1@sss.pgh.pa.us>
Date: Fri, 25 Nov 2022 12:06:15 -0500
Message-ID: <4066263.1669395975@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/4066263.1669395975%40sss.pgh.pa.us>
Precedence: bulk

Israel Barth Rubio <barthisrael@gmail.com> writes:
> It would be great if we can back-patch this to all supported versions,
> as the issue itself is currently affecting them all.

In my mind, this is waiting for Peter to opine on whether it satisfies
his concern.

I'm also looking for input on whether to reject if

    if ((MyXactFlags & XACT_FLAGS_PIPELINING) &&
        GetTopTransactionIdIfAny() != InvalidTransactionId)

rather than just the bare

    if (MyXactFlags & XACT_FLAGS_PIPELINING)

tests in the patch-as-posted.

			regards, tom lane