From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Andres Freund <andres@anarazel.de>, Richard Guo <guofenglinux@gmail.com>,
        =?UTF-8?B?55SE5piO5rSL?= <zhenmingyang@yeah.net>,
        pgsql-bugs@postgresql.org
Subject: Re: A structure has changed but comment modifications maybe missed
In-reply-to: 
 <CAApHDvpS1veLtizEvUiQyhcP-uR7=7gnaDn1kPW3pPbeX95X1A@mail.gmail.com>
References: <1a96696c.9d3.187193989c3.Coremail.zhenmingyang@yeah.net>
 <CAMbWs4817qLtBLNOM51VH=+tbkU42v4VaP_AgvMjurF_vO2-Cw@mail.gmail.com>
 <CAMbWs4_OwkHKO+21z=KF1tdObzoozqcD2r+UM81gmNihQfnj0w@mail.gmail.com>
 <CAApHDvpS1veLtizEvUiQyhcP-uR7=7gnaDn1kPW3pPbeX95X1A@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Thu, 30 Mar 2023 14:55:53 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4119643.1680141729.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 29 Mar 2023 22:02:09 -0400
Message-ID: <4119644.1680141729@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/4119644.1680141729%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> I think the attached is what you have in mind. Can you confirm?

tts_nvalid is still a thing, so I question your edit here:

--- a/src/include/executor/tuptable.h
+++ b/src/include/executor/tuptable.h
@@ -68,8 +68,7 @@
  * A TupleTableSlot can also be "empty", indicated by flag TTS_FLAG_EMPTY=
 set
  * in tts_flags, holding no valid data.  This is the only valid state for=
 a
  * freshly-created slot that has not yet had a tuple descriptor assigned =
to
- * it.  In this state, TTS_SHOULDFREE should not be set in tts_flags, tts=
_tuple
- * must be NULL and tts_nvalid zero.
+ * it.  In this state, TTS_FLAG_SHOULDFREE should not be set in tts_flags=
.
  *
  * The tupleDescriptor is simply referenced, not copied, by the TupleTabl=
eSlot
  * code.  The caller of ExecSetSlotDescriptor() is responsible for provid=
ing

Andres would really be the expert about these changes though.

			regards, tom lane