Message-ID: <41c94ff6-e6c8-4844-a67d-e5fd545f457f@iki.fi>
Date: Tue, 20 May 2025 10:45:07 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: BUG #18929: After the view is created, executed query against the
 view definition, reported syntax error.
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: 707330139@qq.com, pgsql-bugs@lists.postgresql.org
References: <18929-077d6b7093b176e2@postgresql.org>
 <349f86e9-6922-4fcc-9725-b8a6f0667bea@iki.fi>
 <c8706ea7-5a32-434b-bdc8-6cf8e2ad46c1@iki.fi>
 <614740.1747715486@sss.pgh.pa.us> <aCwM3RSlrD2mk1mT@paquier.xyz>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <aCwM3RSlrD2mk1mT@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/41c94ff6-e6c8-4844-a67d-e5fd545f457f%40iki.fi>
Precedence: bulk

On 20/05/2025 08:02, Michael Paquier wrote:
> On Tue, May 20, 2025 at 12:31:26AM -0400, Tom Lane wrote:
>> In the no-good-deed-goes-unpunished department: it appears from
>> buildfarm reports that we need to do something about output
>> mismatches in cross-version-upgrade tests due to this commit.
>> I didn't yet look more closely.
> 
> Yes, the buildfarm is unhappy.
> 
> It seems to me that this needs an update of @_unused_view_qualifiers
> in AdjustUpgrade.pm to update public.limit_thousand_v_5's qual, like
> in the attached.  This is needed in v16 and newer branches.

Committed the same fix.  Sorry for not crediting you in the commit 
message, I reached the same conclusion and committed before I saw this 
discussion. Thanks for looking!

-- 
Heikki Linnakangas
Neon (https://neon.tech)