From: Tom Lane <tgl@sss.pgh.pa.us>
To: exclusion@gmail.com
cc: pgsql-bugs@lists.postgresql.org, Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: BUG #17828: postgres_fdw leaks file descriptors on error and
 aborts aborted transaction in lack of fds
In-reply-to: <17828-122da8cba23236be@postgresql.org>
References: <17828-122da8cba23236be@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Thu, 09 Mar 2023 12:00:01 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <423730.1678381075.1@sss.pgh.pa.us>
Date: Thu, 09 Mar 2023 11:57:55 -0500
Message-ID: <423731.1678381075@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/423731.1678381075%40sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> The following script:
> [ leaks a file descriptor per error ]

Yeah, at least on platforms where WaitEventSets own kernel file
descriptors.  I don't think it's postgres_fdw's fault though,
but that of ExecAppendAsyncEventWait, which is ignoring the
possibility of failing partway through.  It looks like it'd be
sufficient to add a PG_CATCH or PG_FINALLY block there to make
sure the WaitEventSet is disposed of properly --- fortunately,
it doesn't need to have any longer lifespan than that one
function.

			regards, tom lane