Feedback-ID: i131946ab:Fastmail
Message-ID: <428169fe-2eb3-4415-a5be-6f59112f26b2@enterprisedb.com>
Date: Wed, 7 Dec 2022 13:04:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.1
Subject: Re: CREATE COLLATION without LOCALE throws error in v15
Content-Language: en-US
To: Jeff Davis <pgsql@j-davis.com>, Kyle Spearrin <kspearrin@bitwarden.com>,
 pgsql-bugs@lists.postgresql.org
Cc: Justin Baur <jbaur@bitwarden.com>, Vince Grassia <vgrassia@bitwarden.com>
References: 
 <CALDQics_oBEYfOnu_zH6yw9WR1waPCmcrqxQ8+39hK3Op=z2UQ@mail.gmail.com>
 <7b99b4a7fc5284008bae32b77a776d25b4a400bc.camel@j-davis.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <7b99b4a7fc5284008bae32b77a776d25b4a400bc.camel@j-davis.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/428169fe-2eb3-4415-a5be-6f59112f26b2%40enterprisedb.com>
Precedence: bulk

On 07.12.22 00:57, Jeff Davis wrote:
> On Fri, 2022-12-02 at 14:14 -0500, Kyle Spearrin wrote:
>> However, in Postgres 15 we see the following error:
>>
>> ERROR:  parameter "locale" must be specified
> 
> I agree that this is some kind of bug. The docs seem pretty clear[1]:
> 
>    "locale
> 
>      This is a shortcut for setting LC_COLLATE and LC_CTYPE
>      at once. If you specify this, you cannot specify either
>      of those parameters."
> 
> The error appears to come from commit f2553d4306 ("Add option to use
> ICU as global locale provider"). My guess is that it was seen as
> clearer to write LOCALE, and that the error wasn't expected to cause
> anyone a problem.

This was an intentional change because of underlying conceptual and 
catalog changes.  lc_collate, lc_ctype, and iculocale are now tracked 
separately in the catalogs.  This is also important because for a 
database they actually are used separately.  So this also keeps the 
locale/collation settings for databases and collations consistent.

The "locale" parameter is now basically "default for whatever settings 
are appropriate for the locale provider".  We should change the 
documentation in that direction.