Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kDYjU-0003Sy-4n
	for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Sep 2020 19:47:48 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1kDYjS-0002LA-OP
	for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Sep 2020 19:47:46 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kDYjS-0002L3-IF
	for pgsql-bugs@lists.postgresql.org; Wed, 02 Sep 2020 19:47:46 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kDYjP-0006AA-Mi
	for pgsql-bugs@lists.postgresql.org; Wed, 02 Sep 2020 19:47:45 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 082JleZV428208;
	Wed, 2 Sep 2020 15:47:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: "David G. Johnston" <david.g.johnston@gmail.com>, exclusion@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16486: Prompted password is ignored when password specified
 in connection string
In-reply-to: <20200901203846.GA13613@momjian.us>
References: <16486-b9c93d71c02c4907@postgresql.org>
 <2090524.1591652199@sss.pgh.pa.us>
 <CAKFQuwbk=SDVVhe=P=eAsX4Zip_0tR+vZOOMM-VvHAH0=We=_g@mail.gmail.com>
 <2110959.1591655226@sss.pgh.pa.us> <2142411.1591667958@sss.pgh.pa.us>
 <20200901203846.GA13613@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Tue, 01 Sep 2020 16:38:46 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <428206.1599076060.1@sss.pgh.pa.us>
Date: Wed, 02 Sep 2020 15:47:40 -0400
Message-ID: <428207.1599076060@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> I used a later version of Tom's patch to add documentation of how
> connection strings can override command-line options, plus it has the
> password description improvements.

>          <option>--all</option>) is not used, the database name is read
>          from the environment variable <envar>PGDATABASE</envar>.  If
>          that is not set, the user name specified for the connection is
> -        used.
> +        used.  <link linkend="libpq-connstring">Connction strings</link>
> +        can also be used for connection specifications, and these can
> +        override other command-line options.
>         </para>
>        </listitem>
>       </varlistentry>

* Spellcheck (not "Connction" please)

* I do not like the wording "can override", because that's just impossibly
vague.  It leaves the reader wondering whether there are cases where that
doesn't happen.

I'd suggest wording more like

    The <replaceable>dbname</replaceable> can be a
    <link ...>connection string</link>.  If so, connection parameters
    found in the connection string will override any conflicting command
    line options, such as <option>--username</option>.

			regards, tom lane