From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ewan Young <kdbase.hack@gmail.com>
cc: Alexander Lakhin <exclusion@gmail.com>,
        Andrey Rachitskiy <pl0h0yp1@gmail.com>, michaelmalis2@gmail.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19595: Three memory-safety defects in
 src/backend/tsearch/spell.c (dictionary loader), PG 18.3
In-reply-to: 
 <CAON2xHN3QmsaySM6DGWa1gttcbJoFh0wjAE-_ZpSPo=LKN1hYw@mail.gmail.com>
References: <19595-7dc18b4e212c4757@postgresql.org>
 <CAB8bMiun+cTqTnv-cTfxvTbnOLxWunRgyZeUZ88YMSLLXub4mg@mail.gmail.com>
 <325748.1785691547@sss.pgh.pa.us>
 <0f3ddeb5-0dbd-479c-9d0e-ae254758e624@gmail.com>
 <336527.1785701494@sss.pgh.pa.us>
 <CAON2xHN3QmsaySM6DGWa1gttcbJoFh0wjAE-_ZpSPo=LKN1hYw@mail.gmail.com>
Comments: In-reply-to Ewan Young <kdbase.hack@gmail.com>
	message dated "Mon, 24 Aug 2026 19:20:42 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <431727.1788048897.1@sss.pgh.pa.us>
Date: Sat, 29 Aug 2026 20:14:57 -0400
Message-ID: <431728.1788048897@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/431728.1788048897%40sss.pgh.pa.us>
Precedence: bulk

Ewan Young <kdbase.hack@gmail.com> writes:
> One more problem in the same file.  It is not one of the three in the
> original report - those were all on the affix-rule side (CompoundAffix,
> the flag buffer, the AF alias table), while this one is in the compound
> flag table - and it is older than all of them, the code being from 9.6.
> So I'm posting here rather than opening a new report.

Pushed, thanks for the report!

I noticed while reading your patch that all of the strtol() calls in
this file store the result into an "int" not a "long", which opens
the door to an undetected integer overflow and truncation.  Nothing
terribly harmful seems likely to ensue, but I thought I'd clean that
up too while we're here.

			regards, tom lane