From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Jacob Champion <jchampion@timescale.com>, heath.lord@crunchydata.com,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than
 PG14 when SSL is not in use for the connection
In-reply-to: <B9EC60EC-F665-47E8-A221-398C76E382C9@yesql.se>
References: <17625-fc47c78b7d71b534@postgresql.org>
 <346263.1664480998@sss.pgh.pa.us> <360379.1664482591@sss.pgh.pa.us>
 <CAAWbhmhYNOubS2qTx3rG8V2STZ9F0SrtRBuPJimCwRYAQ6r3BQ@mail.gmail.com>
 <395956.1664484332@sss.pgh.pa.us>
 <B9EC60EC-F665-47E8-A221-398C76E382C9@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Thu, 29 Sep 2022 23:10:48 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <432063.1664486954.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 29 Sep 2022 17:29:14 -0400
Message-ID: <432064.1664486954@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/432064.1664486954%40sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> Reading a few lines further down in the docs I noticed this description =
for the
> compression parameter to PQsslAttribute:

> 	"If SSL compression is in use, returns the name of the compression
> 	algorithm, or "on" if compression is used but the algorithm is not
> 	known.  If compression is not in use, returns "off"."

> AFAICT that has never been the case since 91fa7b4719ac, it has always ju=
st
> returned "on" or "off" and never the name of the compression algorithm. =
 I
> propose to apply the attached backpatched to make the docs align with th=
e code.

Yeah, it clearly doesn't do that.  +1

			regards, tom lane