Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIims-0003aY-6L for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Apr 2019 23:55:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hIimp-0007Wo-Hu for pgsql-bugs@arkaria.postgresql.org; Mon, 22 Apr 2019 23:55:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIimp-0007PV-4Z for pgsql-bugs@lists.postgresql.org; Mon, 22 Apr 2019 23:55:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIime-0004pH-KF for pgsql-bugs@lists.postgresql.org; Mon, 22 Apr 2019 23:55:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x3MNtYMW000435; Mon, 22 Apr 2019 19:55:34 -0400 From: Tom Lane To: "Jonathan S. Katz" cc: Michael Paquier , pgsql-bugs@lists.postgresql.org, Stephen Frost Subject: Re: Possible to store invalid SCRAM-SHA-256 Passwords In-reply-to: <15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org> References: <016deb6b-1f0a-8e9f-1833-a8675b170aa9@postgresql.org> <4240a41f-a957-fd7d-7c24-31683f259b9d@postgresql.org> <20190422015051.GA3433@paquier.xyz> <3033.1555940554@sss.pgh.pa.us> <5a93333c-dde6-ee52-f870-4dccfc50eb6f@postgresql.org> <30284.1555972921@sss.pgh.pa.us> <15140775-08c3-45bd-6dab-fdcd290d1bf0@postgresql.org> Comments: In-reply-to "Jonathan S. Katz" message dated "Mon, 22 Apr 2019 19:36:45 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <433.1555977334.1@sss.pgh.pa.us> Date: Mon, 22 Apr 2019 19:55:34 -0400 Message-ID: <434.1555977334@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk "Jonathan S. Katz" writes: > I debated adding a test...without being able to simulate a log in, I > don't know if it tests much other than "yes, you can store an invalid > md5 hash and it treats it as plaintext." You could probably build something using TAP testing, cf src/test/authentication/t/001_password.pl But I really doubt it's worth the trouble ... regards, tom lane