pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedMinor update on pg_hba documentation
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2024-06-05 fbff304c57 75714e7cae doc: Fix example with database regexp in HBA documentation
* Minor update on pg_hba documentation
@ 2024-06-04 15:22 SAS <sas.postgresql@gmail.com>
2024-06-05 03:30 ` Re: Minor update on pg_hba documentation David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: SAS @ 2024-06-04 15:22 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org
Hi,
I wonder if there is an extra word that should be suppressed on the PG 16
client-auth.sgml file.
In the example for the regex on database name, the TYPE is "local" and contains
the word "localhost" for ADDRESS. Shouldn't it be omitted ?
Best regards,
--
Dr Stéphane Schildknecht
Contact régional PostgreSQL pour l'Europe francophone
+33 617 11 37 42
Attachments:
client-auth.sgml.patch (text/x-patch, 661B) download
diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml
index cf5eb22fc89..c57abcdb277 100644
--- a/doc/src/sgml/client-auth.sgml
+++ b/doc/src/sgml/client-auth.sgml
@@ -815,7 +815,7 @@ host all all localhost trust
# "db12").
#
# TYPE DATABASE USER ADDRESS METHOD
-local db1,"/^db\d{2,4}$",db2 all localhost trust
+local db1,"/^db\d{2,4}$",db2 all trust
# Allow any user from any host with IP address 192.168.93.x to connect
# to database "postgres" as the same user name that ident reports for
* Re: Minor update on pg_hba documentation
2024-06-04 15:22 Minor update on pg_hba documentation SAS <sas.postgresql@gmail.com>
@ 2024-06-05 03:30 ` David G. Johnston <david.g.johnston@gmail.com>
2024-06-05 06:33 ` Re: Minor update on pg_hba documentation Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 4+ messages in thread
From: David G. Johnston @ 2024-06-05 03:30 UTC (permalink / raw)
To: SAS <sas.postgresql@gmail.com>; +Cc: pgsql-bugs@lists.postgresql.org
On Tue, Jun 4, 2024 at 8:22 AM SAS <sas.postgresql@gmail.com> wrote:
> In the example for the regex on database name, the TYPE is "local" and
> contains the word "localhost" for ADDRESS. Shouldn't it be omitted ?
>
I'd suggest changing local to host and leave the address alone. Having a
local example at that spot seems odd since everything around it is host and
the text ties them together.
David J.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Minor update on pg_hba documentation
2024-06-04 15:22 Minor update on pg_hba documentation SAS <sas.postgresql@gmail.com>
2024-06-05 03:30 ` Re: Minor update on pg_hba documentation David G. Johnston <david.g.johnston@gmail.com>
@ 2024-06-05 06:33 ` Michael Paquier <michael@paquier.xyz>
2024-06-05 11:19 ` Re: Minor update on pg_hba documentation Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 4+ messages in thread
From: Michael Paquier @ 2024-06-05 06:33 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: SAS <sas.postgresql@gmail.com>; pgsql-bugs@lists.postgresql.org
On Tue, Jun 04, 2024 at 08:30:30PM -0700, David G. Johnston wrote:
> On Tue, Jun 4, 2024 at 8:22 AM SAS <sas.postgresql@gmail.com> wrote:
>
> > In the example for the regex on database name, the TYPE is "local" and
> > contains the word "localhost" for ADDRESS. Shouldn't it be omitted ?
> >
> I'd suggest changing local to host and leave the address alone. Having a
> local example at that spot seems odd since everything around it is host and
> the text ties them together.
My fault on this one. My intention was likely to use "host". I'll go
fix it this way. Nice catch.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Minor update on pg_hba documentation
2024-06-04 15:22 Minor update on pg_hba documentation SAS <sas.postgresql@gmail.com>
2024-06-05 03:30 ` Re: Minor update on pg_hba documentation David G. Johnston <david.g.johnston@gmail.com>
2024-06-05 06:33 ` Re: Minor update on pg_hba documentation Michael Paquier <michael@paquier.xyz>
@ 2024-06-05 11:19 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 4+ messages in thread
From: Michael Paquier @ 2024-06-05 11:19 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: SAS <sas.postgresql@gmail.com>; pgsql-bugs@lists.postgresql.org
On Wed, Jun 05, 2024 at 03:33:02PM +0900, Michael Paquier wrote:
> My fault on this one. My intention was likely to use "host". I'll go
> fix it this way. Nice catch.
On top of using David's suggestion, I have also tweaked the format of
this HBA entry to make it aligned with the rest.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-06-05 11:19 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-06-04 15:22 Minor update on pg_hba documentation SAS <sas.postgresql@gmail.com>
2024-06-05 03:30 ` David G. Johnston <david.g.johnston@gmail.com>
2024-06-05 06:33 ` Michael Paquier <michael@paquier.xyz>
2024-06-05 11:19 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox