Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6YOz-00Dmys-B7 for pgsql-bugs@arkaria.postgresql.org; Thu, 31 Oct 2024 16:52:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t6YOx-003WP8-9j for pgsql-bugs@arkaria.postgresql.org; Thu, 31 Oct 2024 16:52:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6XIl-002bMi-6K for pgsql-bugs@lists.postgresql.org; Thu, 31 Oct 2024 15:41:35 +0000 Received: from stravinsky.debian.org ([2001:41b8:202:deb::311:108]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6XIe-0041QI-Qm for pgsql-bugs@lists.postgresql.org; Thu, 31 Oct 2024 15:41:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Content-Type:MIME-Version:Message-ID: Date:Subject:To:From:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=t6+ey57Uugn0LR0gB4WBQ7MWaDir0J9w3jm9QYr2QK0=; b=j9tDR1pGkSk7DqGDGh8bmXW9+i GiCryxG38R7y/HyWkGAd8fXfXRXnoqZb+yudEbtknOpA23GhU58LW5lPX8phSYnLb6HqxcZBK5D2j 4FF3HPJgb4EmhlPnzwzAKYPy9fANIn/nDqAcgXTWFT0DEqP9yx0zAUI6HcTcMVADOr557osxxDftA 8neGP8yIekD/jHQM/sAskoTX3ccvNdJ6HhHC336flPlV3S1I0lYOLssoqD5aw6VZwOx1r4S55cckK XRzntDab2SpWqdBXOaar7V7yWAipecbXnpINCMadqcsPMdWfEwyZ8ftvHHxK1HiexW/ClUDD9RWKw KACoL5XQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1t6XIc-0096vJ-4L; Thu, 31 Oct 2024 15:41:26 +0000 From: Bastien =?ISO-8859-1?Q?Roucari=E8s?= To: pgsql-bugs@lists.postgresql.org Subject: Detection of hadware feature => please do not use signal Date: Thu, 31 Oct 2024 15:41:24 +0000 Message-ID: <4496616.iHFcN1HehY@portable-bastien> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3549613.blXqYrR0kk"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Debian-User: rouca List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --nextPart3549613.blXqYrR0kk Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Bastien =?ISO-8859-1?Q?Roucari=E8s?= To: pgsql-bugs@lists.postgresql.org Subject: Detection of hadware feature => please do not use signal Date: Thu, 31 Oct 2024 15:41:06 +0000 Message-ID: <4496616.iHFcN1HehY@portable-bastien> MIME-Version: 1.0 Hi, On debian side we will like to avoid use of sigill to detect feature. https://sources.debian.org/src/postgresql-17/17.0-1/src/port/pg_crc32c_armv8_choose.c/#L55 is really bad. Could you use the canonical way under linux #include #include #if defined(__aarch64__) return !(getauxval(AT_HWCAP) & HWCAP_CRC32); #else return !(getauxval(AT_HWCAP2) & HWCAP2_CRC32); #endif Thanks Rouca --nextPart3549613.blXqYrR0kk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEXQGHuUCiRbrXsPVqADoaLapBCF8FAmcjpRIACgkQADoaLapB CF+F4w//YVXpugsDf3pujxp3zflOaubhi0YMpLFcS3BzpwmUpo0upFM4gwBiny7K UKChTZ/E+Al39eqcEHu44bPnnihoAFyQ1yYa8cEqlaUx0KWg1KUaIpSMTuFT9cev 0P13bNh1/brAjud2Vtb7bF9FHssA+PIHyvdi1Kx5RpwkbFeAuoyz0oCuaulx432h Kk4kZY3C0mAyGbLVE41h6zQkFk8xZ6eCXHnVBdNHPUWVudv3JAMiz3F77tHXPB+7 GDF2YEbfoCoQIY6V3tMtfWcCozJM7KbprxA3nUzNC+lSJ5Z6wjxPj0yosGzumP0r ggwc83G3e2ZhAU7yq/PG91bqdel59wH/svNWRKZeIfXGpfm72mClFJdA45u9nmdF Og3DkDzWLq8tXh1gkNIgXJ5WnTtJ0iLMGlzmjx3A+b3N8TBJxRo9UZk6ZmMXD9xw CY8S3wz5WYMO0LBqLM1rTKG5PxR3B29iA/ab1BGzwh/wIX5yVqgCfmHUkzjALIBe PjtDyDlluiUwzmAWcCe66xDWQrVMYfnGkiBjdYe85dbWMQXZPObdIispQfUMQSUR n0fYIIc0b045Fb9+9JgWiNu5nHUCdvu1fuT5XunXV24XKptJpDDyqIcWPy0EOTTk wfWFF8KRPBtRWmasjuqgVJ6MRlazAoyMtxcrN16YiKh/KgIpcRk= =yW08 -----END PGP SIGNATURE----- --nextPart3549613.blXqYrR0kk--