Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAiXf-0007ih-7s for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2022 02:21:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pAiXe-0006nq-3L for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2022 02:21:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAiUe-0002UD-7z for pgsql-hackers@lists.postgresql.org; Thu, 29 Dec 2022 02:18:04 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAiUX-0005ZM-Rj for pgsql-hackers@lists.postgresql.org; Thu, 29 Dec 2022 02:18:03 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2BT2HsU3451606; Wed, 28 Dec 2022 21:17:54 -0500 From: Tom Lane To: Justin Pryzby cc: Peter Geoghegan , postgresql@taljaren.se, pgsql-hackers@lists.postgresql.org, Michael Paquier Subject: Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) In-reply-to: <20221229012354.GF1153@telsasoft.com> References: <17717-6c50eb1c7d23a886@postgresql.org> <3439037.1671130590@sss.pgh.pa.us> <3544447.1671141436@sss.pgh.pa.us> <3672943.1671202149@sss.pgh.pa.us> <407579.1672258403@sss.pgh.pa.us> <20221229012354.GF1153@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Wed, 28 Dec 2022 19:23:54 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <451604.1672280274.1@sss.pgh.pa.us> Date: Wed, 28 Dec 2022 21:17:54 -0500 Message-ID: <451605.1672280274@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > On Wed, Dec 28, 2022 at 03:13:23PM -0500, Tom Lane wrote: >> I'm forced to the conclusion that we have to expose some VACUUM >> options if we want this to work well. Attached is a draft patch >> that invents SKIP_DATABASE_STATS and ONLY_DATABASE_STATS options >> (name bikeshedding welcome) and teaches vacuumdb to use them. > I assumed it would look like: > VACUUM (UPDATE_DATABASE_STATS {yes,no,only}) Meh. We could do it like that, but I think options that look like booleans but aren't are messy. regards, tom lane