Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNtrd-0001Ls-3d for pgsql-bugs@arkaria.postgresql.org; Wed, 08 Sep 2021 09:27:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mNtrY-00042b-Tx for pgsql-bugs@arkaria.postgresql.org; Wed, 08 Sep 2021 09:27:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNtrY-00042T-8I for pgsql-bugs@lists.postgresql.org; Wed, 08 Sep 2021 09:27:24 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNtrT-0004Cd-9J for pgsql-bugs@lists.postgresql.org; Wed, 08 Sep 2021 09:27:23 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B5C735C019A; Wed, 8 Sep 2021 05:27:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 08 Sep 2021 05:27:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=3GG9rjdrmDeGEx5Yx2r4/45hxCfkTj8cYlNTVXtPw Ks=; b=msC4tqzTb7ciMvaaN+E/wLezFIY+Da1H/7ucanyYZ+4lup+OsEt4bYi/P RtFfAqLKnxtyVvc72375eIC1pH2fjumslsdzyjWOOG8HZI7MsbiO3ePghR3f6r9C jdnRR7mFVxp3+cG7Tf1ZMTNp7Pzg4z/2y5DP8vk4sSq8cv7wau2YSNtZHPR6Nlbc 6OS/Ubt4lHcwUc6NzKZPoppCRDyTyoI0WzPUuY3fb2ryhi0U6hG5AE/NRxB/0lAX FJyzcBw3kWpMzikRCy1EOuXk8aX4eRdOoqYUp04twoCPkYIcwSf5qXCquuoGNLxd TTlSV2LsYoxl5Od0A1aHPjSP+9NAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefjedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuhffvfhfkffgfgggjtgfgsehtke ertddtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghr rdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrg htthgvrhhnpefffeegleejtedtvdeigfekkeevgfeludevtefgheetfeelteetjeeuheeg geduheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Sep 2021 05:27:13 -0400 (EDT) Subject: Re: BUG #17158: Distinct ROW fails with Postgres 14 From: Peter Eisentraut To: Tom Lane Cc: David Rowley , sait.nisanci@microsoft.com, PostgreSQL mailing lists References: <17158-8a2ba823982537a4@postgresql.org> <496046.1629843371@sss.pgh.pa.us> <2021952.1630442634@sss.pgh.pa.us> <7fb17b3d-13dc-fc28-17ce-9c302d676bd8@enterprisedb.com> Message-ID: <4519d7da-7402-cff3-d577-0bc8511e0c9a@enterprisedb.com> Date: Wed, 8 Sep 2021 11:27:11 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7fb17b3d-13dc-fc28-17ce-9c302d676bd8@enterprisedb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 02.09.21 10:15, Peter Eisentraut wrote: > On 31.08.21 22:43, Tom Lane wrote: >> I find variant 1 a bit cleaner, and safer.  I'd rather default to >> assuming that RECORD doesn't hash, when we don't have enough info >> to be sure. > > Ok, here is a more polished patch for that. committed