From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        "Todd A. Cook" <tcook@blackducksoftware.com>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: BUG #14932: SELECT DISTINCT val FROM table gets stuck in an
 infinite loop
In-reply-to: <20180129170631.kdr2dtu5rodvovhv@alap3.anarazel.de>
References: <219b37b2-d740-d04a-203a-49ae422028f7@blackducksoftware.com>
 <c15378b3-d4aa-a5c0-5538-dd52904dcbc6@2ndquadrant.com>
 <1773c302-2fb1-749f-8ccc-62b23617c5ac@blackducksoftware.com>
 <25629.1512580464@sss.pgh.pa.us>
 <20171206171923.dg7phzfh7nb4lou3@alap3.anarazel.de>
 <7de4b2d6-b119-7d15-04d8-4c0fcb29cbc3@2ndquadrant.com>
 <20180126234537.dyu6jwnqz7snpq7n@alap3.anarazel.de>
 <14184.1517010515@sss.pgh.pa.us>
 <20180129010213.rt3nu73ilff756f6@alap3.anarazel.de>
 <3971fa24-285b-1c57-db95-b15c513162c1@2ndquadrant.com>
 <20180129170631.kdr2dtu5rodvovhv@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 29 Jan 2018 09:06:31 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4594.1517249498.1@sss.pgh.pa.us>
Date: Mon, 29 Jan 2018 13:11:38 -0500
Message-ID: <4595.1517249498@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2018-01-29 14:41:49 +0100, Tomas Vondra wrote:
>> Do you think repeating the performance testing is necessary? Not sure
>> when do you plan to push the changes, I may not have time for the tests
>> until after FOSDEM.

> Hm, it surely wouldn't hurt, but your previous result does give a lot of
> confidence - there's not a lot of fundamental difference leaving one
> more mitigation that should never reduce hashtable "quality" aside.  So
> I think going ahead with pushing and then benchmarking if possible, is
> reasonable?

Since the release wrap is this coming Monday, there's not really time to
wait and do something after FOSDEM ...

			regards, tom lane