Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qREau-000zew-6E for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Aug 2023 16:21:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qREas-006KA5-Db for pgsql-bugs@arkaria.postgresql.org; Wed, 02 Aug 2023 16:21:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qREaq-006K9x-Sf for pgsql-bugs@lists.postgresql.org; Wed, 02 Aug 2023 16:21:02 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qREaj-0009w2-Nq for pgsql-bugs@lists.postgresql.org; Wed, 02 Aug 2023 16:21:00 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6B79E5C00BB; Wed, 2 Aug 2023 12:20:50 -0400 (EDT) Received: from imap49 ([10.202.2.99]) by compute6.internal (MEProxy); Wed, 02 Aug 2023 12:20:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1690993250; x=1691079650; bh=s6 3haVAKtp8hywSUWnfv3jT6y7P9gWpUhaUTiUA86gA=; b=nTOxyejp5lxLH+mEFF T4cdgyloRq+P9drHlBjmbqEM96ME/zC4V/t97WbycXhKNgZfMeKUdzRt7ibHrB9I 1Yi82UXftxgyb7t/CFBK44Q7eG/buYE1BMVRd414ixK0wEiFCN8AqiXFtSqNh2uJ ORty6trWDUuGYxvo7AgsJrtyT0P8FVLqVwjw0Ta161vV6rbkX7UuQZ1Q6EyrpFPg s+BVpWZS2hDSng4eSQJWHl4dxatI7TIPWtl3hlqBA1DHP81DM3dk2r3bYo8xGkXQ Lu7SR5IQCNwl3+yWZ/WYtAWvGL4WdvIcssgEYCVNRjvN7W4AJCpQgJ0Pr8cUjHMG KNJA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690993250; x=1691079650; bh=s63haVAKtp8hy wSUWnfv3jT6y7P9gWpUhaUTiUA86gA=; b=MwMFniEHC6dTDpXq5ALKUCKoeHxb6 bgAgTbIjvzLbcCXymhQ0JQnQWituVZS9i+OGHsVFWqvpXWRbrlKrxQFbfPpyH2lq 2yRT4wHhNJNv8MbdSRWsL0f+MPIhB/erjzpHAB/5sjWRAMMjCaY/TuULYoYlRVlW 6yzVfortCsh+5YH6glBzom4clY23a3j+X+PWX9icguHGIHIA4T498j9IphYI2Kji 42YjiQo3QXjg7h7xUxWWSYVtggpIdw4nJVp6jFrZx7LSU0eiZZ/wz3pn3wnSuJDQ JQFqeVW/qAGiGn866zQCo8ncKbnjf1DS+GaRAiSUVwenkZ53WnL37YLYA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrkedtgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesrgdtreerreertdenucfhrhhomhepfdfguhhl vghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvghrthhordgtohhmqeenucggtf frrghtthgvrhhnpeehvdevueeljeekfeeliefhfeefgfffgeeufefhvdeugedttdegvdeh uedvgfdugfenucffohhmrghinhepphhoshhtghhrvghsqhhlrdhorhhgpdgvnhhtvghrph hrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpegvuhhlvghrsegvuhhlvghrthhordgtohhm X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9519D15A0091; Wed, 2 Aug 2023 12:20:49 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440 Mime-Version: 1.0 Message-Id: <46011cbb-74e0-4e7d-9a78-b7857cc62918@app.fastmail.com> In-Reply-To: References: <1567990.1690217495@sss.pgh.pa.us> Date: Wed, 02 Aug 2023 13:20:29 -0300 From: "Euler Taveira" To: "Zechman, Derek S" , "Tom Lane" Cc: "pgsql-bugs@lists.postgresql.org" Subject: Re: pg_hba.conf "authentication file token too long, skipping" Content-Type: multipart/alternative; boundary=e7d8aaa38d2446c0aa7b00f5a3085a73 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --e7d8aaa38d2446c0aa7b00f5a3085a73 Content-Type: text/plain On Tue, Aug 1, 2023, at 1:29 PM, Zechman, Derek S wrote: > " A one-line improvement would be to increase that constant, but it doesn't look very much harder to get rid of that fixed-size buffer altogether in favor of a StringInfo." > > Is this something that can be included in the next patch? Tom pushed patches for all supported back branches that raises the token length from 256 to 10240 [1]. If it is a v13 or earlier [2], it also requires to change the limit of line length (from 8192 to 20480). In v16 this limit was completely eliminated using StringInfo [3]. In summary, this improvement will be available in the next minor releases. [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=313ceda2fe2ee8dd903ad4773f54de14807807c6 [2] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=0660f74e861d0dc942af3e0b5f88cb2f0c72aee5 [3] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=de3f0e3fe0e7d44620111c5723504a3a6e8c046e -- Euler Taveira EDB https://www.enterprisedb.com/ --e7d8aaa38d2446c0aa7b00f5a3085a73 Content-Type: text/html Content-Transfer-Encoding: quoted-printable
On Tue, Aug 1, = 2023, at 1:29 PM, Zechman, Derek S wrote:
" A one-line improvement would be to incr= ease that constant, but it doesn't look very much harder to get rid of t= hat fixed-size buffer altogether in favor of a StringInfo."

Is this something that can be included in the next patc= h?

Tom pushed patches for all = supported back branches that raises the token length
from = 256 to 10240 [1]. If it is a v13 or earlier [2], it also requires to
=
change the limit of line length (from 8192 to 20480). In v16 = this limit was
completely eliminated using StringInfo [3].=

In summary, this improvement will be avail= able in the next minor releases.


--e7d8aaa38d2446c0aa7b00f5a3085a73--