Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBsIw-0001Al-0z for pgsql-bugs@arkaria.postgresql.org; Tue, 16 Feb 2021 04:49:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lBsIu-0004kl-FE for pgsql-bugs@arkaria.postgresql.org; Tue, 16 Feb 2021 04:49:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBsIu-0004gN-90 for pgsql-bugs@lists.postgresql.org; Tue, 16 Feb 2021 04:49:40 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBsIr-0004ex-8d for pgsql-bugs@lists.postgresql.org; Tue, 16 Feb 2021 04:49:39 +0000 Received: from hnk.local (p2710230-ipbf1703funabasi.chiba.ocn.ne.jp [123.216.93.230]) by oss.nttdata.com (Postfix) with ESMTPSA id C86B86281E; Tue, 16 Feb 2021 13:49:33 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: BUG #16867: savepoints vs. commit and chain To: Arthur Nascimento , pgsql-bugs@lists.postgresql.org References: <16867-3475744069228158@postgresql.org> From: Fujii Masao Message-ID: <473dba6b-dfb3-b5a8-93c6-af3787893728@oss.nttdata.com> Date: Tue, 16 Feb 2021 13:49:33 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------0B4E01A88BB4EE106590289E" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------0B4E01A88BB4EE106590289E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2021/02/16 6:47, Arthur Nascimento wrote: > On Mon, 15 Feb 2021 at 17:54, PG Bug reporting form > wrote: >> On a trivial transaction, I might do: >> >> =# begin; >> *=# commit and chain; >> *=# -- In this point I'm inside a second transaction > > I forgot to mention that this case also works as expected: > > =# begin; > *=# savepoint foo; > *=# release foo; > *=# commit and chain; > *=# -- In this point I'm also inside a second transaction > > So it's only the unmatched savepoint/release transactions that are an issue. > > I also attached the change I did to psql locally. LGTM. > But since it didn't > solve the issue, it's mostly for curiosity's sake. In the server side, ISTM that CommitTransactionCommand() needs to handle the COMMIT AND CHAIN in TBLOCK_SUBCOMMIT case, but it forgot to do that. Patch attached. I'm not sure if this is a bug or an intentional behavior. Probably we need to look at the past discussion about AND CHAIN feature. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------0B4E01A88BB4EE106590289E Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="savepoint_and_chain.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="savepoint_and_chain.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hhY3QuYyBiL3NyYy9i YWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hhY3QuYwppbmRleCAxN2ZiYzQxYmJiLi40ZTZhM2Rm NmI4IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9hY2Nlc3MvdHJhbnNhbS94YWN0LmMKKysr IGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGFjdC5jCkBAIC0zMTA1LDYgKzMxMDUs MTMgQEAgQ29tbWl0VHJhbnNhY3Rpb25Db21tYW5kKHZvaWQpCiAJCQkJQXNzZXJ0KHMtPnBh cmVudCA9PSBOVUxMKTsKIAkJCQlDb21taXRUcmFuc2FjdGlvbigpOwogCQkJCXMtPmJsb2Nr U3RhdGUgPSBUQkxPQ0tfREVGQVVMVDsKKwkJCQlpZiAocy0+Y2hhaW4pCisJCQkJeworCQkJ CQlTdGFydFRyYW5zYWN0aW9uKCk7CisJCQkJCXMtPmJsb2NrU3RhdGUgPSBUQkxPQ0tfSU5Q Uk9HUkVTUzsKKwkJCQkJcy0+Y2hhaW4gPSBmYWxzZTsKKwkJCQkJUmVzdG9yZVRyYW5zYWN0 aW9uQ2hhcmFjdGVyaXN0aWNzKCk7CisJCQkJfQogCQkJfQogCQkJZWxzZSBpZiAocy0+Ymxv Y2tTdGF0ZSA9PSBUQkxPQ0tfUFJFUEFSRSkKIAkJCXsKZGlmZiAtLWdpdCBhL3NyYy90ZXN0 L3JlZ3Jlc3MvZXhwZWN0ZWQvdHJhbnNhY3Rpb25zLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3Mv ZXhwZWN0ZWQvdHJhbnNhY3Rpb25zLm91dAppbmRleCAxYjAzMzEwMDI5Li43NWRjNjU1OGQ4 IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3RyYW5zYWN0aW9ucy5v dXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC90cmFuc2FjdGlvbnMub3V0CkBA IC03NzQsNiArNzc0LDQ2IEBAIFNIT1cgdHJhbnNhY3Rpb25fZGVmZXJyYWJsZTsKICgxIHJv dykKIAogSU5TRVJUIElOVE8gYWJjIFZBTFVFUyAoNSk7CitDT01NSVQ7CitTVEFSVCBUUkFO U0FDVElPTiBJU09MQVRJT04gTEVWRUwgUkVQRUFUQUJMRSBSRUFELCBSRUFEIFdSSVRFLCBE RUZFUlJBQkxFOworU0hPVyB0cmFuc2FjdGlvbl9pc29sYXRpb247CisgdHJhbnNhY3Rpb25f aXNvbGF0aW9uIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyByZXBlYXRhYmxlIHJlYWQK KygxIHJvdykKKworU0hPVyB0cmFuc2FjdGlvbl9yZWFkX29ubHk7CisgdHJhbnNhY3Rpb25f cmVhZF9vbmx5IAorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyBvZmYKKygxIHJvdykKKwor U0hPVyB0cmFuc2FjdGlvbl9kZWZlcnJhYmxlOworIHRyYW5zYWN0aW9uX2RlZmVycmFibGUg CistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyBvbgorKDEgcm93KQorCitTQVZFUE9JTlQg eDsKK0NPTU1JVCBBTkQgQ0hBSU47ICAtLSBUQkxPQ0tfU1VCQ09NTUlUCitTSE9XIHRyYW5z YWN0aW9uX2lzb2xhdGlvbjsKKyB0cmFuc2FjdGlvbl9pc29sYXRpb24gCistLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQorIHJlcGVhdGFibGUgcmVhZAorKDEgcm93KQorCitTSE9XIHRyYW5z YWN0aW9uX3JlYWRfb25seTsKKyB0cmFuc2FjdGlvbl9yZWFkX29ubHkgCistLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQorIG9mZgorKDEgcm93KQorCitTSE9XIHRyYW5zYWN0aW9uX2RlZmVy cmFibGU7CisgdHJhbnNhY3Rpb25fZGVmZXJyYWJsZSAKKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQorIG9uCisoMSByb3cpCisKIENPTU1JVDsKIC0tIGRpZmZlcmVudCBtaXggb2Ygb3B0 aW9ucyBqdXN0IGZvciBmdW4KIFNUQVJUIFRSQU5TQUNUSU9OIElTT0xBVElPTiBMRVZFTCBT RVJJQUxJWkFCTEUsIFJFQUQgV1JJVEUsIE5PVCBERUZFUlJBQkxFOwpkaWZmIC0tZ2l0IGEv c3JjL3Rlc3QvcmVncmVzcy9zcWwvdHJhbnNhY3Rpb25zLnNxbCBiL3NyYy90ZXN0L3JlZ3Jl c3Mvc3FsL3RyYW5zYWN0aW9ucy5zcWwKaW5kZXggYmYxMDE2NDg5ZC4uZDFiNmVkMDI4MCAx MDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvdHJhbnNhY3Rpb25zLnNxbAorKysg Yi9zcmMvdGVzdC9yZWdyZXNzL3NxbC90cmFuc2FjdGlvbnMuc3FsCkBAIC00NTgsNiArNDU4 LDE3IEBAIFNIT1cgdHJhbnNhY3Rpb25fZGVmZXJyYWJsZTsKIElOU0VSVCBJTlRPIGFiYyBW QUxVRVMgKDUpOwogQ09NTUlUOwogCitTVEFSVCBUUkFOU0FDVElPTiBJU09MQVRJT04gTEVW RUwgUkVQRUFUQUJMRSBSRUFELCBSRUFEIFdSSVRFLCBERUZFUlJBQkxFOworU0hPVyB0cmFu c2FjdGlvbl9pc29sYXRpb247CitTSE9XIHRyYW5zYWN0aW9uX3JlYWRfb25seTsKK1NIT1cg dHJhbnNhY3Rpb25fZGVmZXJyYWJsZTsKK1NBVkVQT0lOVCB4OworQ09NTUlUIEFORCBDSEFJ TjsgIC0tIFRCTE9DS19TVUJDT01NSVQKK1NIT1cgdHJhbnNhY3Rpb25faXNvbGF0aW9uOwor U0hPVyB0cmFuc2FjdGlvbl9yZWFkX29ubHk7CitTSE9XIHRyYW5zYWN0aW9uX2RlZmVycmFi bGU7CitDT01NSVQ7CisKIC0tIGRpZmZlcmVudCBtaXggb2Ygb3B0aW9ucyBqdXN0IGZvciBm dW4KIFNUQVJUIFRSQU5TQUNUSU9OIElTT0xBVElPTiBMRVZFTCBTRVJJQUxJWkFCTEUsIFJF QUQgV1JJVEUsIE5PVCBERUZFUlJBQkxFOwogU0hPVyB0cmFuc2FjdGlvbl9pc29sYXRpb247 Cg== --------------0B4E01A88BB4EE106590289E--