From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Laurenz Albe <laurenz.albe@cybertec.at>,
        Nisha Moond <nisha.moond412@gmail.com>,
        Gunnar Morling <gunnar.morling@googlemail.com>,
        "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
In-reply-to: <472687.1751731008@sss.pgh.pa.us>
References: 
 <CADGJaX_0+FTguWpNSpgVWYQP_7MhoO0D8=cp4XozSQgaZ40Odw@mail.gmail.com>
 <CABdArM76e8-XChodqKxEiRK3tR_Yv3cymn_AWfP4bOsLDscZAg@mail.gmail.com>
 <30e91649-06dd-453e-8658-5f4acd03a3bd@oss.nttdata.com>
 <b26f13d7-769a-4b64-8bed-cb3a833c0604@oss.nttdata.com>
 <686577f2379e4b978803e72746dcf0dd7baf3937.camel@cybertec.at>
 <e0789f10-5b48-4d6b-a32c-0f4426d254df@oss.nttdata.com>
 <CAA4eK1LOyUeCHk3hMtjT-bpqXLAnjODwcO+o7+bTnB2es-fSqw@mail.gmail.com>
 <70b183fb-f66e-40d8-b0de-be8c1052fa93@oss.nttdata.com>
 <CAKFQuwYVEgy+fiHMvSoykiEef-VF-ZV9Gxv4rynk9NNK9UMPYQ@mail.gmail.com>
 <472687.1751731008@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sat, 05 Jul 2025 11:56:48 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <474267.1751731988.1@sss.pgh.pa.us>
Date: Sat, 05 Jul 2025 12:13:08 -0400
Message-ID: <474268.1751731988@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/474268.1751731988%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> I'm kind of down on changing the unit, because it will *silently*
> break configuration files where the value was set without a unit.

Oh, wait a second.  I just noticed that this variable is new in v18.
So there won't be a compatibility issue as long as we change it in
v18 too.  So changing it to a base of seconds seems sufficient,
and more in line with existing practice:

regression=# select name,unit from pg_settings where name like '%timeout';
                name                 | unit 
-------------------------------------+------
 archive_timeout                     | s
 authentication_timeout              | s
 checkpoint_timeout                  | s
 deadlock_timeout                    | ms
 idle_in_transaction_session_timeout | ms
 idle_replication_slot_timeout       | min
 idle_session_timeout                | ms
 lock_timeout                        | ms
 statement_timeout                   | ms
 tcp_user_timeout                    | ms
 transaction_timeout                 | ms
 wal_receiver_timeout                | ms
 wal_sender_timeout                  | ms
(13 rows)

Using 'ms' seems clearly overkill, but there's precedent for
timeouts measured in seconds.

			regards, tom lane