Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: BUG #19095: Test if function exit() is used fail when linked
 static
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <CACTYHzhCNsee-4xv-HDhw8zmMWByB7YHLuUHh-bsztgZ94ewpw@mail.gmail.com>
Date: Tue, 25 Nov 2025 11:51:55 +0100
Cc: Michael Paquier <michael@paquier.xyz>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 BharatDB <bharatdbpg@gmail.com>,
 torsten.rupp@gmx.net,
 pgsql-bugs@lists.postgresql.org,
 byavuz81@gmail.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <483765ED-0490-4972-9769-4943716BE204@yesql.se>
References: <19095-6d8256d0c37d4be2@postgresql.org>
 <CAAh00ETwx8_AEM0wgoi-v875uC-FLuGGOMTaP9fCNdVw4Zq=Vg@mail.gmail.com>
 <2305435.1762929527@sss.pgh.pa.us>
 <7C7B32ED-5742-49D5-9380-5E02AA5B03C4@yesql.se>
 <aRRCE_2ydBfCnO7Q@paquier.xyz>
 <057A2AED-0116-446B-8986-57FDA70CA5A3@yesql.se>
 <CAN55FZ2Wqv+maXTfNO6+y=5400w7hCMo6RQhasqp=nrsODSBpg@mail.gmail.com>
 <CAN55FZ2em+Wf6kWQ27bwQrLTTWJF7TcSDDKnjxGy+fxMVaGbvg@mail.gmail.com>
 <aSTRj99MkyI5zr0y@paquier.xyz>
 <CACTYHzhCNsee-4xv-HDhw8zmMWByB7YHLuUHh-bsztgZ94ewpw@mail.gmail.com>
To: VASUKI M <vasukim1992002@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/483765ED-0490-4972-9769-4943716BE204%40yesql.se>
Precedence: bulk

> On 25 Nov 2025, at 10:11, VASUKI M <vasukim1992002@gmail.com> wrote:

> Thanks for this suggestion michael & Nazir for the code,i have made =
the changes you said=20
>=20
> Also added the check where it scans for nm in the environment if it is =
not present then it gracefully skips the test.

+if find_program('nm', required: false, native: true).found() and not =
get_option('b_coverage')
Sorry for being late to the party, but I wonder why we aren't adding =
this check
to the toplevel meson.build and configure.ac (via config/programs.m4) =
like how
we check for all others tools used by the build?  Such checks should of =
course
not fail the configuration, merely record the presence or absence of the =
tool.
The path can then be exported to =
src/interfaces/libpq/{Makefile|meson.build} to
use.


+open my $fh, '-|', "$nm_path -A -u $input_file 2>/dev/null"
This filehandle is never closed.


+# ---- Skip entirely on Solaris ----
+if ($Config{osname} =3D~ /solaris/i) {
+    exit 0;
+}
This won't work on Windows either, which wasn't checked for in the =
Makefile
since make isn't used on Windows.

--
Daniel Gustafsson