Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1lyIbS-000302-HQ
	for pgsql-bugs@arkaria.postgresql.org; Tue, 29 Jun 2021 18:36:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1lyIbR-00016p-DP
	for pgsql-bugs@arkaria.postgresql.org; Tue, 29 Jun 2021 18:36:57 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lyIbR-00016h-6r
	for pgsql-bugs@lists.postgresql.org; Tue, 29 Jun 2021 18:36:57 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lyIbP-0008OK-9T
	for pgsql-bugs@lists.postgresql.org; Tue, 29 Jun 2021 18:36:56 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15TIaq3G485565;
	Tue, 29 Jun 2021 14:36:52 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, exclusion@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17076: Server crashes on composing an error message about
 invalid modulus for a new table partition
In-reply-to: 
 <CA+HiwqF+keTbzQqYPR=QtzNon+huzCRcb676eb66NTqPYDARtA@mail.gmail.com>
References: <17076-89a16ae835d329b9@postgresql.org>
 <342122.1624914489@sss.pgh.pa.us> <346711.1624919432@sss.pgh.pa.us>
 <CA+HiwqF+keTbzQqYPR=QtzNon+huzCRcb676eb66NTqPYDARtA@mail.gmail.com>
Comments: In-reply-to Amit Langote <amitlangote09@gmail.com>
	message dated "Tue, 29 Jun 2021 16:11:51 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <485563.1624991812.1@sss.pgh.pa.us>
Date: Tue, 29 Jun 2021 14:36:52 -0400
Message-ID: <485564.1624991812@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/485564.1624991812%40sss.pgh.pa.us>
Precedence: bulk

Amit Langote <amitlangote09@gmail.com> writes:
> On Tue, Jun 29, 2021 at 7:30 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I think the patch has got more problems than that too, as it's far
>>> from clear why the next remainder would have anything to do with the
>>> next larger modulus.

> Yes.  Though, I think the problem is that the code uses
> boundinfo->indexes[<offset>] as an index into partdesc->oids[] array
> to get the existing partition to show in the error message.  The
> correct thing here would be to use <offset> directly.  That is because
> the hash partition bounds as laid out in boudinfo->datums[] correspond
> one-to-one with the partition OIDs laid out in partdesc->oids[].

Got it.  Pushed your fix, along with some twiddling of the nearby
comments which seemed a bit vague.

			regards, tom lane